Giter Site home page Giter Site logo

Comments (8)

kastermester avatar kastermester commented on May 20, 2024 1

For what it is worth, I have also been toying around with something akin to what is in the edition 3 branch. Here's my rust-toolchain.toml file from the root of my workspace. (Note: I'm on an arm macbook, as such I cannot remember if the target also needs to be specified here or not):

[toolchain]
channel = "nightly-2023-04-03"
components = ["rust-src", "llvm-tools-preview", "rustfmt", "clippy"]
targets = ["x86_64-unknown-none"]

I suspect the part that is really worth sticking onto is the nightly version.

EDIT: Also my Cargo.toml workspace file is using package.resolver = "2".

from blog_os.

torrancew avatar torrancew commented on May 20, 2024 1

@Momijiichigo I would also recommend adding a kernel/.cargo/config.toml and specifying the following, to make everything a bit easier to reproduce:

[unstable]
build-std = ["core", "compiler_builtins"]

[build]
target = "x86_64-unknown-none"

It's also worth considering pinning a specific nightly version in your toolchain file, and specifying your targets:

[toolchain]
channel = "nightly-2023-09-04"
components = ["rust-src", "llvm-tools-preview"]
targets = ["x86_64-unknown-none"]

Both of these make it a bit more reliable for others cloning your repo to reproduce your environment.

from blog_os.

bjorn3 avatar bjorn3 commented on May 20, 2024

Blog os required bootloader 0.9. It doesn't work with any later version of the bootloader crate as these rework the way building disk images is done.

from blog_os.

fooooooooooooooo avatar fooooooooooooooo commented on May 20, 2024

Blog os required bootloader 0.9. It doesn't work with any later version of the bootloader crate as these rework the way building disk images is done.

they are following the draft of edition 3 which uses 0.11

from blog_os.

bjorn3 avatar bjorn3 commented on May 20, 2024

I see. I think this is a cargo bug in the bin deps feature. I would guess it unified features between the kernel itself and the crate that builds the disk image.

from blog_os.

Momijiichigo avatar Momijiichigo commented on May 20, 2024

@kastermester Thank you so much!!!
Adding resolver = "2" in the Cargo.toml solved the problem!! I never thought about that!!

from blog_os.

Momijiichigo avatar Momijiichigo commented on May 20, 2024

@torrancew thanks for the advice!
Now I'm closing this issue since it's resolved

from blog_os.

phil-opp avatar phil-opp commented on May 20, 2024

As an alternative to resolver = "2", you can also set edition = "2021" where the new resolver is the default. You already set the edition for your sub-crates, but not for the root crate.

from blog_os.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.