Comments (6)
Sorry went back through history - I see you've dropped support for 1.7, will close.
from django-rest-framework-filters.
Thanks @threehundred! We should probably restrict the Django version in our setup.py, so I'm re-opening this issue.
from django-rest-framework-filters.
@philipn I'm kind of wondering what should be done here. A couple of thoughts:
- If we want to specify a minimum Django version, should we or should django-filter do this? ie, we're an extension of django-filter, which is an extension of Django. For all intents and purposes, we have the same compatibility guarantees as django-filter (also notice that the actual error in the trace was thrown from django-filter).
- There is some push to not specify Django in the requires section. See jazzband/django-model-utils#183. In short, it can cause some issues across multiple pip installs.
- A lot of projects don't specify django in the requires. eg, DRF, django-filter
from django-rest-framework-filters.
Hmm. You're totally right that few apps seem to list a Django dependency. No strong opinion, but my 2c--
It seems like people should be pinning their version of Django in their project's requirements (and using something sweet like https://github.com/nvie/pip-tools, to boot!) If they did, they'd never have problems like in the linked ticket(s). In the linked ticket, @carljm says "[django] doesn't need any automatic dependency handling", but this kind of issue is exactly why the dependency would help people -- they'd find out there's a problem during installation rather than at run time.
I wonder what kind of problem is more common -- hitting an unknown error during an upgrade because a package hasn't been tested / support has dropped for your version of Django, or having Django automatically upgraded and not wanting that behavior.
from django-rest-framework-filters.
Thinking back,
- Adding Django as a dependency creates a problem for development environments, not deployments. eg, you would
pip install -U djangorestframework-filters
to test out the latest changes, and then accidentally update Django itself. Installing from a requirements file should complain about conflicts. - drf-filters is more an extension of django-filter than it is an extension of Django. The django-filter dependency should be sufficient?
- drf-filters at least supports all currently supported versions of Django. I think the real answer here is "Don't use an outdated and unsupported version of Django".
from django-rest-framework-filters.
@philipn - Are we agreed that django shouldn't be listed as a requirement? Closing this as it's an easy modification if you decide otherwise.
from django-rest-framework-filters.
Related Issues (20)
- Django 3 support HOT 1
- RecursionError for circular self relationship HOT 1
- filter on two model HOT 1
- Trying out ComplexJSONFilterBackend HOT 1
- ImportError: cannot import name 'six' from 'django.utils' HOT 1
- Specify Model Dynamiclly HOT 2
- TypeError: 'Meta.fields' must not contain non-model field names HOT 2
- Is this project still alive? HOT 3
- CI status failures HOT 1
- Invalid filter for properties of model of RelatedMultipleFilter HOT 1
- Ordering (sorting) from URL in ComplexFilterBackend HOT 1
- Combining filters for multi-valued relationships with `AND` HOT 2
- RelatedMultipleFilter doesn't work as expected HOT 1
- django-rest-framework-filters does not seem to support RelatedFilters with non-default relationships
- PROPOSAL: Custom help text for FilterSet
- ImportError: cannot import name 'QUERY_TERMS' from 'django.db.models.sql.constants'
- Django 4.x compatibility HOT 5
- Consider transferring ownership to Jazzband HOT 2
- How to use the field 'in' in django-rest-framework-filters, like 'user_id__in=[12,13]'? HOT 2
- Tests fail with Django 4.2: ImportError: cannot import name 'url' from 'django.conf.urls'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-rest-framework-filters.