Comments (7)
Yes, cast(void*)
is pretty much breaking the type system, in terms of changing type qualifiers or lifetime attributes. This shouldn't be required if the compiler could construct a DAG of the lifetimes and do these checks properly, but you can read more about the issue in the referenced bugzilla tickets on the PR you just mentioned.
from pegged.
New release: v0.4.7.
from pegged.
I need to finish something I promised but end up getting at the bottom of my task list.
from pegged.
For context, this is it: #314 (comment).
To be fair, that change is likely necessary only when dmd#14236 gets merged, and that PR has currently stalled (@dkorpel). So we could decide to tag Pegged now if we remember to make the change before a new DMD release makes that necessary.
It seems a rather trivial change, though, so @iK4tsu if you want to have a go at it, maybe @ljmf00-wekaio can review it and we can release without pending TODO's.
from pegged.
Yes, if you can @iK4tsu, I appreciate. It's basically implement something like:
/**
* Assume non scope variable
*
* This function casts away scope attribute from the given parameter.
*
* Params:
* arg = The scope variable to cast scope away
*
* Returns: the variable `arg` as is, but without scope attribute.
*
* Note: This breaks the language type system.
*/
@nogc
auto ref assumeNonScope(T)(auto ref scope T arg)
{
return *cast(T*)cast(void*)&arg;
}
And use in the dip1000 hacks I added.
Also, worth mentioning @dkorpel that the hack with size_t
doesn't work with all types, hence I use void*
.
from pegged.
* Note: This breaks the language type system.
Could you help me understand why it is necessary to break the language type system? Is it because the compiler gets it wrong (#314 (comment))?
from pegged.
Yes, if you can @iK4tsu, I appreciate. It's basically implement something like:
/** * Assume non scope variable * * This function casts away scope attribute from the given parameter. * * Params: * arg = The scope variable to cast scope away * * Returns: the variable `arg` as is, but without scope attribute. * * Note: This breaks the language type system. */ @nogc auto ref assumeNonScope(T)(auto ref scope T arg) { return *cast(T*)cast(void*)&arg; }And use in the dip1000 hacks I added. Also, worth mentioning @dkorpel that the hack with
size_t
doesn't work with all types, hence I usevoid*
.
casting to void*
does not cast away scope
from pegged.
Related Issues (20)
- is it okay for the D grammar to compile in 10 minutes and use 45 gigs of ram? HOT 14
- Run-time parsing of Peg grammars HOT 1
- qualifiedIdentifier in dgrammar.d is not defined HOT 2
- Add equivalent of “important” blocks? HOT 3
- Release 0.4.5 HOT 2
- `pure` and `@safe` grammars/rules? HOT 3
- Can't fix this failure. HOT 2
- Grammar won't parse whole text, it stops short a few lines... HOT 1
- Comment syntax HOT 7
- Unwanted space consumption in rule parameter
- Syntax wrappers HOT 1
- How does one do Intellisense using a Pegged grammar? HOT 3
- Is there a way to break up a grammar into D classes, each with their own data to parse into & thus subgrammar? HOT 2
- I can't find the Wikipedia ParseTree handling code in the Pegged wiki any more... HOT 1
- Will there be a speed-up when using a Dlang switch-case and shorter pegged variable names? HOT 2
- Can we create a grammar induction algorithm based upon expected Pegged parsing failures? HOT 2
- How do you use dub + pegged + asModule? HOT 1
- Remove obsolete CI.
- How do you branch on complex names such as caseSensitiveLiteral!("let") (they get much more complicated) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pegged.