Cross reference array gives an empty array

[philipstanislaus]

Cross reference array gives an empty array

[philipstanislaus]

Good find, I agree, there should be an error on circular structures.

[philipstanislaus]

Would you have time to create a PR for this?

[kh0ma]

Temporary in my project I did it the following way:

• call arrayToTree with a given array
• count entries in Tree
• compare the length of an array vs "length" of Tree

Here we can count on Tree length w/o needs to recalculate it. So will validate it at the end.

Do we care about backward compatibility?

Should it be a config throwIfCircular: true similar to throwIfOrphans: true?

[philipstanislaus]

Sorry for the delay in resolving this.

I just checked out the current code, and realized that this is actually a special case of throwIfOrphans, since any items with a circular parent/child relationship would just be a group of orphans that will not be part of the tree.

[philipstanislaus]

Released in https://www.npmjs.com/package/performant-array-to-tree/v/1.10.0