Fullscreen doesn't work with awesome wm

[phillipberndt]

Fullscreen doesn't work with awesome wm

[phillipberndt]

I'll be on vacation for the next two weeks, but afterwards, I'll have a look.

For now: I suspect that this is (partially) a WM bug. Fullscreening in X11 happens via a hint to the WM, and it's the WM's responsibility to resize and place the window accordingly. (I do have some code in place to fullscreen when using -f and there is no WM present though, but that shouldn't trigger when you fullscreen using the f key or your WM's controls.) In your screenshot, the window covers only half the screen, so clearly something went wrong when resizing. For starters, you could test if other fullscreen applications work. Run the following Python script (needs pygtk):

import gtk
w = gtk.Window()
w.connect("hide", gtk.main_quit)
w.show()
# Try playing around with the aspect ratio (values from 0.0 to 1.0) and/or size requests
# I suspect that the aspect ratio plays a role
#aspect = 1
#w.set_size_request(400, 600)
#w.set_geometry_hints(min_aspect=aspect, max_aspect=aspect)
w.fullscreen()
gtk.main()

It should display an empty, fullscreen window. (Quit with your wm's hotkey)

[adia]

Thanks for the quick reply!

Other full-screen apps seem to work correctly (that's why I asked here first) but the script above behaves inconsistently depending on the size request and aspect ratio, although if it requests the same size as the screen (1280x1024), full-screen works whatever the aspect.

I'll try asking about this at the awesome mailing list and report back.

[phillipberndt]

I've been able to reproduce the bug. IMHO, what you experience is a bug in awesome wm. I haven't been able to track down the bug to its source though - their function for applying the aspect ratio, client_apply_size_hints, is not involved in the call to client_resize_do with the wrong geometry, but the bug still depends on requesting an aspect ratio not fitting the screen's prior to going fullscreen.

However, I think I've found a workaround. See the awesome-fs-bugfix branch.

[adia]

Thanks for tracking the problem down and the workaround! This change indeed makes everything work correctly. Do you plan to incorporate it into the next release?

I'm sorry, I didn't ask awesome's developers about the problem yet, but I intend to do it right now, referencing this bug report.

[phillipberndt]

I think so, because it does not seem to have any side effects. I'll do some further testing beforehand though..