Giter Site home page Giter Site logo

Comments (5)

jjcarstens avatar jjcarstens commented on May 5, 2024 1

Thanks for the tip! That gets me pointed in the right direction so if I find some time I can take a gander as well.

Looks like both our selectors work (at least testing within the console), but yours definitely reads easier.

Here's a quick test case that I've been using (in case you need it)

<!-- Test selector: div#error:not(.invisible) -->
<div class="foo" id="error">Should match!</div>
<div class="bar invisible" id="error">..No match..</div>

from floki.

Eiji7 avatar Eiji7 commented on May 5, 2024 1

More info: Pseudo-classes at MDN and Selectors Level 4 Editor’s Draft, 27 January 2017..

from floki.

philss avatar philss commented on May 5, 2024

Hi @jjcarstens!

This feature would be really cool to have!

I think the correct syntax for your selector is div#error:not(.invisible).

For the implementation we would probably change a little bit the selector parser and perhaps add some rules or change the lexer to consider a simple selector inside the :not parenthesis.

Here is the W3C specs for :not() pseudo-class: https://drafts.csswg.org/selectors-3/#negation

I'm gonna let this open for a while until I can work on this. Feel free to give a try if you want too.

Thanks!

from floki.

philss avatar philss commented on May 5, 2024

@Eiji7 thank you for the links! I think we could have a separated issue for this suggestion you made. Can you create that and add examples?

from floki.

philss avatar philss commented on May 5, 2024

@jjcarstens implemented in #93.

Closing the issue. I will take a look in another pseudo-classes before releasing a new version.
I'm gonna let you know here.

from floki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.