Comments (5)
Thanks for the tip! That gets me pointed in the right direction so if I find some time I can take a gander as well.
Looks like both our selectors work (at least testing within the console), but yours definitely reads easier.
Here's a quick test case that I've been using (in case you need it)
<!-- Test selector: div#error:not(.invisible) -->
<div class="foo" id="error">Should match!</div>
<div class="bar invisible" id="error">..No match..</div>
from floki.
More info: Pseudo-classes at MDN and Selectors Level 4 Editor’s Draft, 27 January 2017..
from floki.
Hi @jjcarstens!
This feature would be really cool to have!
I think the correct syntax for your selector is div#error:not(.invisible)
.
For the implementation we would probably change a little bit the selector parser and perhaps add some rules or change the lexer to consider a simple selector inside the :not
parenthesis.
Here is the W3C specs for :not()
pseudo-class: https://drafts.csswg.org/selectors-3/#negation
I'm gonna let this open for a while until I can work on this. Feel free to give a try if you want too.
Thanks!
from floki.
@Eiji7 thank you for the links! I think we could have a separated issue for this suggestion you made. Can you create that and add examples?
from floki.
@jjcarstens implemented in #93.
Closing the issue. I will take a look in another pseudo-classes before releasing a new version.
I'm gonna let you know here.
from floki.
Related Issues (20)
- Unhandled error for Floki.parse_fragment/2 HOT 1
- CDATA inside a title tag is not handled in Mochiweb parser
- Is there a way to replace paragraph tags by newlines in Floki.text()? HOT 1
- Proposal: Add Floki.Doc HOT 10
- Drop support for Elixir 1.11
- Allow option to parse attributes as maps HOT 9
- Floki is extremely noisy in logs
- Support for :has pseudo selector
- Error after upgrading to 0.35.0 HOT 6
- Buttons in Header Section Lacks Transition!!
- Floki attribute example is ambiguous
- Proposal: optimized find for simple cases HOT 5
- Is it possible to get line/column number of a tag? HOT 4
- Unexpected order using `find` with comma separated selectors in v0.35.3 HOT 2
- nth-child selector not working as expected HOT 7
- Floki.raw_html/2 no longer respects `config :floki, :encode_raw_html, false` HOT 1
- Add functionality to escape values in selectors
- Issue with an archive uploaded to hex HOT 3
- Empty tag attributes are not parsed correctly HOT 1
- issues with fetching floki as dependeny
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from floki.