Floki.find returning unmatching nodes

[philss]

Floki.find returning unmatching nodes

[mmmries]

Thanks for the release and pointing me in the right direction to work on a fix 💙 💛 💚

[mmmries]

BTW thanks for doing this project. It has been very useful so far and I'd be happy to spend some time trying to fix this bug if you can point me in the right general direction of where I should look.

[philss]

Hi @mmmries!

Thanks for the report. This is definitely a bug. Not sure why, but is selecting a wrong node.
I'm investigating this.

[philss]

@mmmries I found the problem, but I'm not sure how to fix yet. It is here: https://github.com/philss/floki/blob/master/lib/floki/finder.ex#L202-L210

We should take all the children ids based on the list of ids that are between the current node and the sibling node. This works when there is a sibling, but don't work when the node is the last node inside his parent.

I have one idea that I will try to implement. Feel free to give a try too.

Thanks!

[mmmries]

@philss thanks for pointing me in the right direction. I'll take a look and see if I can better understand that section of code specifically. Hopefully I can make an attempt at a fix before you get there so you can take me to 🏫

[philss]

@mmmries nice! One way to make sure it takes all descendant nodes is to traverse the nodes that are below the current node and adding them to the stack right in that process.
This would avoid the idea of taking the ids of what we assume it's a subtree, which theoretically is simpler. But would be a little bit harder to implement since we would have to traverse and accumulate the results.

[philss]

@mmmries This fix was released in v0.12.1. Thank you again!