Comments (7)
I suspect the problem here is that the NuGet targets that know how to handle PackageReference
are only included with the .NET Core SDK. It's possible that Visual Studio does some magic to locate those targets even for classic .NET project files. I also see an interesting comment to the docs here:
PackageReference can be used with non-NETCore projects if the project system supports it--so the real answer depends on Unity itself. As for NuGet, it checks if the project supports VSProject4 to determine if it can read/write PackageReferences
This also suggests there's some kind of connection to the VS project system.
Are you able to submit your tests as a PR so I can bring them in? Once we've got the failing tests merged we can take it from there.
from buildalyzer.
Sure thing. Created #37.
from buildalyzer.
Looks like this got worse. I'm now completely unable to use this library to load up a full framework solution which has project to project references. Not sure what changed, but I think it has to do with a recent Visual Studio update. Any progress on this issue?
from buildalyzer.
Not with this issue specifically, but I'll be pushing a new release within the hour that addresses the broader problems you described. Recently, every time VS or the .NET Core SDK updates Buildalyzer breaks because the MSBuild APIs that it uses aren't compatible with the newest MSBuild stuff in the SDK.
from buildalyzer.
Been chasing this down and I'm pretty sure at this point that the .NET Core SDK can't build legacy project files that use PackageReference
(even though it can build legacy project files). The problem is a missing ResolveNugetPackageAssets
target:
I've verified this by running dotnet build
on the command line for the LegacyFrameworkProjectWithPackageReference
test, and it fails to restore and reference the PackageReference
too.
I'm going to attempt to identify this special case and revert to the framework build tools when it's encountered.
from buildalyzer.
Using the .NET Framework tools from .NET Core did resolve the PackageReference
but the problem now is that attempting to use the .NET Framework tools from a .NET Core host results in several task assemblies not being able to be loaded because they're built for .NET Framework.
from buildalyzer.
Going to close this as "won't fix" due to a limitation with MSBuild: you simply can't build a legacy project file that uses PackageReference
from a .NET Core host. It works under VS because VS can act as a .NET Framework host.
from buildalyzer.
Related Issues (20)
- How to do a (fast) design-time build? HOT 7
- AWS porting assistant crashes on Buildalyzer.ProjectAnalyzer.Build HOT 2
- Support for .Net Standard 2.0 HOT 2
- `PublishSingleFile` breaks `IProjectAnalyzer.Build()` HOT 15
- Version number not available for packages added using GlobalPackageReference in Directory.Packages.props HOT 7
- Unsupported log file version HOT 8
- Cache dotnet info results per global.json file HOT 5
- Error when trying to read dotnet --info HOT 3
- multiple Buildalyzer.Tests unit tests are failing HOT 3
- Make working directory used by ProcessRunner configurable HOT 3
- [Discussion] Calling `GetCompilationAsync` on ASP.NET Framework project returns empty compilation HOT 3
- Help offered HOT 1
- Could not load file or assembly `NuGet.Frameworks` HOT 16
- Build/assembly reference not found errors due to random sorting of the projects in the Workspace when loading projects from solution file HOT 9
- Xml documentation is missing for imported symbols in Roslyn Projects HOT 3
- Looking For A New Maintainer HOT 4
- Sponsoring HOT 4
- Coding style, static code analysis, and versioning HOT 15
- Immutability HOT 3
- Targeting netstandard HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildalyzer.