Giter Site home page Giter Site logo

Comments (6)

chrismccord avatar chrismccord commented on June 2, 2024 1

Please share the details of the collisions you hit. Thanks!

from phoenix.

kyleboe avatar kyleboe commented on June 2, 2024

I'm happy to open a PR for the proposed solution. Just want to see if there is a more apt name than depends-on or if there is some configuration I am missing.

from phoenix.

kyleboe avatar kyleboe commented on June 2, 2024

I'm a dummy. That's what the --app flag does.

from phoenix.

kyleboe avatar kyleboe commented on June 2, 2024

Ok actually I'm not as dumb as I thought (what a sentence).

There are some subtle differences that should be addressed. When passing the --app flag there are other collisions in the generator.

from phoenix.

kyleboe avatar kyleboe commented on June 2, 2024

Ah yeah sorry I've been working on the PR to fix it. The collisions were in the generated app name. While the parent folder reflects the name passed as the argument (bar in my example) the contents the folder reflect value of the --app flag.

The most clear example of this was in the apps/bar/mix.exs that started with:

defmodule Foo.MixProject do

As well as apps/bar/lib/foo.ex

from phoenix.

kyleboe avatar kyleboe commented on June 2, 2024

PR #5691 fixes things in the context of the test suite as well as local manual testing.

from phoenix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.