PECL

[php-ds]

PECL

[rtheunissen]

@shouze I noticed that too, and I have no idea why the version information doesn't show up for the classes. There's also https://github.com/php-ds/docs/issues/4 which I'm still trying to debug. I'll open an issue there - let's move discussion over to the docs repo for now.

[rtheunissen]

Released 1.0.2 as stable. Can now install via pecl install ds or download DLL's.

[krakjoe]

I have created the package in PECL ...

• Request a pecl account (Check "Need a php.net account?" ... I'll +1 it, I'm sure others will too ...)
• I will set you as lead on package.
• Add package.xml for PECL (I can do that initially, or you can look at any pecl package and have a go yourself)
• Profit.

Releases are done via a web interface thing, you'll be able to figure that out when you have a login.

The same php.net account will be used for committing stuff for #5, when we get there ...

I should have let you do it the normal way maybe ... if anyone complains (they might) I'll delete the package, and you can follow the instructions in the account request page ... hopefully they'll just let us crack on ...

[rtheunissen]

💸

[rtheunissen]

I've submitted a request, will report on progress.

[krakjoe]

Set as lead on package.

You want to have a go at package.xml, or want me to commit initial one ?

[rtheunissen]

I'll make an attempt, would be good to become familiar.

[krakjoe]

Good (read: correct) call ;)

[rtheunissen]

✨

[rtheunissen]

Added draft package.xml

1. Should we be using the PHP license?
2. Why do we have to list all the files?
3. Is an "alpha" release a valid release type?

PS: Files will change during refactor.

[krakjoe]

Should we be using the PHP license?

While the project is outside of php-src, the MIT license is fine, causes no problems with dist process.

When the project is part of php-src, it will be a good idea to swap over to the PHP license.

If that happens early, there is no loss ...

Why do we have to list all the files?

The package.xml file is used to create release tarballs, the files you include in there are included in the release tarball (composer.json can be left out, so can .travis.yml etc).

Is an "alpha" release a valid release type?

As far as I know, although I've never used it ...

PS: Files will change during refactor.

That's fine, this is only for practice ;)

The required minimum version of php in package.xml should be adjusted past the inclusion of the resolution for #16

[rtheunissen]

The required minimum version of php in package.xml should be adjusted past the inclusion of the resolution for #16

Can't find a clear closed bug report for it..

[krakjoe]

Ping @nikic, can you dig up that commit for us please Nikita ?

[rtheunissen]

Linked in #16

The bug report notes that allow_null fixes it. I noticed that the arginfo entry was the only case where allow_null was false. I've updated the arginfo to enable allow_null, so our version is not affected by the bug.

[listepo]

@rtheunissen what do you think about the .deb and rpm packages?

[shouze]

@rtheunissen any chance to push the 1st release on pecl soon? We're using ds since about 2 months on some project and (except maybe some leaks, we didn't check well) we didn't encounter any problem.

Tell me how I can help on remaining issues to make this happen.

[rtheunissen]

@shouze I'm working on this every day as we speak. My focus at the moment is on source refactoring, leaving only documentation left. I'm not opposed to an early PECL release without proper documentation, but it's definitely something I hope to get out in the coming weeks.

[shouze]

I understand, maybe I can help on documentation? Not very familiar with php documentation but no pb to GET familiar with quickly.

[rtheunissen]

Most of the documentation is already written under php/include, it's just not in the proper docbook XML format - something which I'm not familiar with either. It's not a requirement for PECL (as far as I know), so I'm open to a pre-stable release without complete documentation. This would also be a good opportunity to "practice" the release schedule.

I don't want to release a stable 1.0.0 without fully integrated XML documentation though.

[shouze]

Ok I'm pretty familiar with docbook I've written some 10 years ago, just have to remember it, will give a try with existing documentation.

[rtheunissen]

Actually it used to be under php/include, it's now just under the polyfill repo. It's been a while since I've gone through everything, but it should serve as a good starting point. I'm working on the refactor branch at the moment, will merge with master before the end of the week then start / assist with the documentation and release.

[rtheunissen]

@shouze have you started on the documentation at all? I'm about to, just wanted to ask before I potentially redo some of what you've already done.

Will be working on it at https://github.com/php-ds/extension/tree/docbook

[shouze]

@rtheunissen not started yet.

[rtheunissen]

@shouze See https://github.com/php-ds/docs

[rtheunissen]

Documentation is coming along nicely. Currently working on Deque, which I'll copy over to Sequence and Vector with a few changes.

That leaves Map, Stack, Queue, PriorityQueue and Set.

@shouze, welcome to help out here. I'll try to get it all done by the end of the weekend anyway, but any help here would fast-track the PECL release.

[shouze]

@rtheunissen great, I've forked https://github.com/php-ds/docs and I take on Map at least this week ;)

[rtheunissen]

@shouze awesome! Let me know if anything is unclear.

[rtheunissen]

@shouze I've done the docs for Map now, leaving only a few small classes and introductions that I'll cover tomorrow. If you have some time and would like to contribute, feel free to pull and render, and create issues for things that are either incorrect, misleading, or confusing. 😄

[rtheunissen]

All docs are now complete. We're ready for PECL. ✨

[shouze]

@rtheunissen waw, what fast you are! ;)

I've fetched & builded locally, I've just noticed something strange ATM:

Despite you have that in docs/versions.xml:

<function name='ds\collection' from='PECL ds &gt;= 1.0.0'/>

Once I build the page looks like:

But it works perfectly for

<function name='ds\sequence::__construct' from='PECL ds &gt;= 1.0.0'/>

[rtheunissen]

@krakjoe mentioned in room 11 but will copy here for the record. Everything has been fixed, the build on PECL is 1.0.1, and I'm waiting to see if the Windows build completes.

Q: Seeing as 1.0.0 is broken and 1.0.1 wasn't released as "stable", is it possible to remove those releases or start over? Or should we just release 1.0.2 as stable and go from there?

[rtheunissen]

Also, do you manually edit package.xml or is there an interface / generator for it? Noticed APCu has a changelog in the package.xml as well. Manual editing or generated?

[rtheunissen]

I'm ready to release as stable and submit the documentation, on standby.

[shouze]

@rtheunissen great work, thank you so much!