Giter Site home page Giter Site logo

Supporting php7 about httplug HOT 4 CLOSED

php-http avatar php-http commented on May 14, 2024
Supporting php7

from httplug.

Comments (4)

hannesvdvreken avatar hannesvdvreken commented on May 14, 2024

As long as PHP 7 is not released, allowing failures on it allows us to not worry about it when it fails because of a breaking change in the consecutive builds of PHP 7 or release candidates.

When PHP 7 is released, it is indeed recommended to remove it from the allow_failures.

from httplug.

dbu avatar dbu commented on May 14, 2024

PHP 7 is in RC state. which means i would not expect much to happen that could affect us here. and if it does we should report it to the PHP 7 maintainers so they can fix it.

I am +1 on the proposal.

Also, seeing that currently the build fails, we really should work on fixing the build for 7. There might be some issue that would lead to a BC break for us to be able to fix it (like doctrine has a problem with the class called String as PHP 7 says this is a reserved word, and they have a class for annotations for that...).

@joelwurtz could you work on fixing the PHP 7 build? we can then still decide whether we allow failures or not - but the stuff that is failing now is likely to keep failing. Maybe its just the phpspec version we use https://travis-ci.org/php-http/httplug/jobs/86556672

from httplug.

joelwurtz avatar joelwurtz commented on May 14, 2024

I think the current break stuff in PHP7 comes more from phpspec than this library (see https://travis-ci.org/phpspec/phpspec/phpspec/jobs/87006391)

from httplug.

sagikazarmark avatar sagikazarmark commented on May 14, 2024

@joelwurtz you are right, failing is because phpspec. AFAIK phpspec guys already work on a fix.

from httplug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.