Comments (5)
from php-mock-phpunit.
That is why one should not depend on private implementation details.
from php-mock-phpunit.
My first thought was that this might be similar to when this project failed to work against the minor update to PHPUnit 6.5 sebastianbergmann/phpunit-mock-objects#390 . In that case however, the underlying phpunit-mock-objects had a major version increase to v5.0.0 and the fix was not so simple: #20
This time a public method on the MockObject interface has changed its signature in a minor version of PHPUnit, which does seem like a BC break as any implementation of this method will no longer be compatible.
Fortunately updating the method signature in this project will work with PHPUnit 7.3 and 7.4 as the extra parameter in the implementation does not affect compatibility with the lack of the parameter in PHPUnit 7.3:
interface A {
public function foo();
}
class B {
public function foo(bool $newParam = true) {
echo 'bar';
}
}
(new B())->foo();
from php-mock-phpunit.
Fixed in #30 and released in version 2.1.2.
from php-mock-phpunit.
I confirm the fix is ok.
Thanks for the quick fix.
from php-mock-phpunit.
Related Issues (20)
- phpmock\phpunit\PHPMock not installing HOT 5
- PHPUnit 7 support HOT 3
- Searching new maintainer
- Not work if mocked in test method and tests was run from phpunit command HOT 1
- Add PHPUnit 8 support HOT 1
- Add PHPUnit 8.1 compatibility HOT 2
- Error: Call to undefined method phpmock\phpunit\MockObjectProxyNoReturnTypes::will() HOT 1
- Incompatibility with PHPUnit 8.4 HOT 2
- 'parameters' is private member, use getParameters() instead.
- Declaration of Codeception\Test\Test::toString() must be compatible with PHPUnit\Framework\SelfDescribing::toString(): HOT 3
- Declaration of phpmock\phpunit\MockDisablerPHPUnit6::endTest(PHPUnit\Framework\Test $test, $time) must be compatible with PHPUnit\Framework\BaseTestListener::endTest(PHPUnit\Framework\Test $test, float $time): void in /home/vagrant/Code/boursify-app/vendor/php-mock/php-mock-phpunit/classes/MockDisablerPHPUnit6.php on line 50 HOT 2
- phpunit 8.3: cannot implement PHPUnit\Framework\MockObject\Rule\InvocationOrder HOT 2
- phpspec/prophecy is now explicitely needed for tests HOT 1
- Incompatible declaration of MockDisablerPHPUnit6::endTest HOT 1
- InvocationOrder - it is not an interface HOT 1
- Support PHPUnit 10 HOT 2
- Mocking time function in one test method affects the other
- Incompatible with PHPUnit >= 10.3 HOT 7
- [QUESTION] - Deprecated Methods in phpunit 11 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-mock-phpunit.