Giter Site home page Giter Site logo

[L5.2] Update composer.json about laravel HOT 9 CLOSED

php-tmdb avatar php-tmdb commented on June 7, 2024
[L5.2] Update composer.json

from laravel.

Comments (9)

wtfzdotnet avatar wtfzdotnet commented on June 7, 2024

Could you create a fork with this update and submit a pull request for @MarkRedeman to review? I'm not involved with Laravel so I have no clue what implications there are for backwards compatibility. While you wait for a merge of this fix you can refer to your own fork ( http://mnapoli.fr/overriding-dependencies-with-composer/ ).

from laravel.

MarkRedeman avatar MarkRedeman commented on June 7, 2024

This is currently not possible because TMDB/API depends on version ~2.4.
@wtfzdotnet I did a quick check and it seems that all unit tests are passing when the version of symfony/event-dispatcher is upgraded to ~3.0. Could you verify that it is safe to upgrade to version 3?

from laravel.

MarkRedeman avatar MarkRedeman commented on June 7, 2024

@Rtransat Is there any reason why you need version 3? I've tested the package with Laravel 5.2 and it seems to work out of the box. Are there other packages that require version 3?

from laravel.

florentsorel avatar florentsorel commented on June 7, 2024

I can't check right now but last night composer telling me an error with composer require command about an error with event dispatcher 3.0. It need to install event dispatcher v2 to install the package.

For example, laravel/framework need symfony/http-kernel 2.8 or 3.0 and http-kernel need event-dispatcher ~2.8 or 3.0.

from laravel.

MarkRedeman avatar MarkRedeman commented on June 7, 2024

Then I guess there is some other package that you're using that requires v3.

I've updated PR #25 to change the dependency of event-dispatcher to ~2.8|~3.0, which I will probably merge tonight.

from laravel.

florentsorel avatar florentsorel commented on June 7, 2024

It was a fresh install of laravel and php-tmdb/laravel was the first package I've installed in my new laravel installation.

from laravel.

florentsorel avatar florentsorel commented on June 7, 2024

I just retry and everything works perfectly, no errors with composer. I don't know why composer throw an error yesterday.

from laravel.

MarkRedeman avatar MarkRedeman commented on June 7, 2024

That's quite weird, maybe someone changed its dependencies?

I've updated PR #25 so that it will be fully compatible with event-dispatcher v3.0.

from laravel.

MarkRedeman avatar MarkRedeman commented on June 7, 2024

@Rtransat I've released a new version that is compatible with v3, so I'm closing this issue.

from laravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.