Giter Site home page Giter Site logo

Comments (3)

nielsdos avatar nielsdos commented on August 25, 2024 1

The best solution to this is just removing the offending line I think. That would allow both old and new libxml versions to work. We can only do that on master though for BC reasons. I'll get a PR done.
EDIT: actually that might not be a BC break because the symbol is supposed to be hidden anyway.

from php-src.

nielsdos avatar nielsdos commented on August 25, 2024

Your patch is right, but please keep the file contents sorted alphabetically. Feel free to submit a PR.
EDIT: actually, that won't work because now the build would fail on older libxml versions...

from php-src.

nono303 avatar nono303 commented on August 25, 2024

actually, that won't work because now the build would fail on older libxml versions...

That's why I just opened an issue - not a PR - because I don't know how to manage the switch between libxml version on def files.

from php-src.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.