Property has no typhint when using trait and abstract class

[phpstan]

Property has no typhint when using trait and abstract class

[ServerExe]

We know, we know :) I really appreciate your help, thanks for that. We are taking your advice to heart and are trying to update to the latest version now.

[ondrejmirtes]

What version of PHPStan and the strict-rules package do you have?

On Thu, 18 Jul 2019 at 17:59, RikudouSage ***@***.***> wrote: I have this trait: <?phpnamespace App\Traits;use DateTime;use DateTimeInterface;use Doctrine\ORM\Mapping as ORM;trait EntityCreatedModified{ /** * @var DateTimeInterface|null * @Orm\Column(type="datetime", nullable=true) */ private $created; /** * @var DateTimeInterface|null * @Orm\Column(type="datetime", nullable=true) */ private $updated; public function getCreated(): ?DateTimeInterface { return $this->created; } public function setCreated(?DateTimeInterface $created): self { $this->created = $created; return $this; } public function getUpdated(): ?DateTimeInterface { return $this->updated; } public function setUpdated(?DateTimeInterface $updated): self { $this->updated = $updated; return $this; } /** * @Orm\PrePersist() */ public function onEntityCreated(): void { $this->setCreated(new DateTime()); $this->setUpdated(new DateTime()); } /** * @Orm\PreUpdate() */ public function onEntityUpdated(): void { if (!$this->created) { $this->setCreated(new DateTime()); } $this->setUpdated(new DateTime()); }} Then I have this abstract class: <?phpnamespace App\Entity;use App\Traits\EntityCreatedModified;use Doctrine\ORM\Mapping as ORM;/** * @Orm\MappedSuperclass() */abstract class AbstractBaseEntity{ use EntityCreatedModified;} I get this error: ------ -------------------------------------------------------------------------------------- Line Traits/EntityCreatedModified.php (in context of class App\Entity\AbstractBaseEntity) ------ -------------------------------------------------------------------------------------- 15 Property App\Entity\AbstractBaseEntity::$created has no typehint specified. 21 Property App\Entity\AbstractBaseEntity::$updated has no typehint specified. ------ -------------------------------------------------------------------------------------- When I extend the abstract class or use the trait directly in a concrete class, there is no error. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#84?email_source=notifications&email_token=AAAZTOCUDLDQF7H7EJSTNODQACHPLA5CNFSM4IE5FZP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HABNJ5Q>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOHEXYL2PTJOLN4OED3QACHPLANCNFSM4IE5FZPQ> .

-- Ondřej Mirtes

[RikudouSage]

Both the latest, it's a new project, did fresh install via require today. I can send the exact versions when I get home if you need the numeric versions.

[ondrejmirtes]

Yeah, those versions would be great just for sanity check. For example if you were on PHP 7.0, a really ancient version of PHPStan would be installed by Composer.

[RikudouSage]

phpstan/phpstan - 0.11.12
phpstan/phpstan-strict-rules - 0.11.1
phpstan/phpstan-symfony - 0.11.6

[ondrejmirtes]

When I try to reproduce this locally, I only get this error:

 ------ -------------------------------------------------------------------------------
  Line   EntityCreatedModified.php (in context of class App\Traits\AbstractBaseEntity)
 ------ -------------------------------------------------------------------------------
  61     Only booleans are allowed in a negated boolean, DateTimeInterface|null given.
 ------ -------------------------------------------------------------------------------

Please make sure this isn't a cache problem.

[digitalstraw]

I can confirm that this seemed error in my case with all packages updated.
Helped to delete the cache and all is fine. (On Windows c:\Users\[username]\AppData\Local\Temp\phpstan\).
Hence, I can recommend to close this issue.

[ondrejmirtes]

Thanks!

[ServerExe]

Hm this could not be the proper solution, because even the playground tells me, that there is a missing typehint:
https://phpstan.org/r/ff8bab55-e6da-4544-a8fe-7280c23e8533

[ondrejmirtes]

The playground is currently wrong about things that have something to do with traits. I recommend you to try out locally the latest version and you'll see. Remember to analyse both the class that uses the trait and trait itself in the same run.

[ServerExe]

Ah okay. Thanks for your fast reply, but currently we (our company) are not able to update to the latest version (currently 0.11.9). Updating to the latest dependencies ...

• jangregor/phpstan-prophecy
• phpstan/phpstan
• phpstan/phpstan-phpunit
• phpstan/phpstan-strict-rules

leads to a massive amount of errors because of generics. Of course i could turn off the generics check, but this is not desired, because otherwise all the new code would be ignored.
I guess we have to invest more time to migrate to the major version. And I think there is no doubt, that this is working fine in the latest version :-)

Thank you for your help

[ondrejmirtes]

Can you give me some examples of errors related to generics that you're experiencing?

Anyway, you should definitely find a way to upgrade. You can ignore select errors using regexes. You'll definitely find being able to use the latest version beneficial as it's more capable and has a lot of new features and bugfixes. See these articles to get the idea:

* https://phpstan.org/blog/phpstan-0-12-released

• https://phpstan.org/blog/from-minutes-to-seconds-massive-performance-gains-in-phpstan

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.