Segfault on object construction in JS (on PHP object)

[phpv8]

Segfault on object construction in JS (on PHP object)

[beest]

@stesie this is an interesting one!

I'm not sure what the mechanism is to expose a constructor to JS via the V8 engine. I'd guess this hasn't been covered in the current V8JS code, so this is likely to be a feature that isn't covered yet rather than a bug.

[stesie]

Actually I don't mind if we call this a bug or feature or just issue. After all I stumbled over it, I actually don't need it, but for the moment just wanted to write it down since it crashes the process ...

I guess we can't directly expose the constructor of the PHP class. The v8::FunctionTemplate however has a SetCallHandler method, which according to the API reference

Set the call-handler callback for a FunctionTemplate. This callback is called whenever the function created from this FunctionTemplate is called.

The v8::Arguments passed to the callback function then has a boolean property IsConstructCall, ... which probably is set to true. But haven't done any testing on that.

In that particular case we probably have to create a PHP class instance from v8js, running the PHP class'es __construct function and attach a pointer to the newly allocated PHP class instance to v8's internal field.

I think I'll have a go to implement that the upcoming days, but will concentrate on issue #13 before, as that's more of a show-stopper to me :-)

[stesie]

hey there,

just wanted to let you know that I've started working on a fix to this issue. I already got it working basically, current version at https://github.com/stesie/v8js/commits/fix-constructor-call

cheers,
stesie