Conditionnal forwarding broken after teleporter import

[t4nki]

Conditionnal forwarding broken after teleporter import

[t4nki]

gotta check that out, but if you take a look at my ansible snippet you can see that true is definitely the first value

I have to admit that the first revServers in my second comment is wrong, it should read :
revServers = ["true,10.6.0.0/16,10.6.84.254,lan"]

EDIT: I can confirm, on first launch it shows revServers = ["true,10.6.0.0/16,10.6.84.254,lan"] after clicking import button in teleporter it shows revServers = ["DOMAIN=lan,10.6.0.0/16,10.6.84.254,lan"]

I couldn't find anything in the logs concerning the import action and the subsequent config file modification

[t4nki]

little more info, by parsing pihole.toml I found out that :
revServers = ["lan,10.6.0.0/16,10.6.84.254,lan"]
is changed to :
revServers = ["DOMAIN=lan,10.6.0.0/16,10.6.84.254,lan"]
after hitting import button
That's why everything goes back to normal after I restart the container, as the reverse servers are configured as environment variables in the container

[rdwebdesign]

I found out that : revServers = ["lan,10.6.0.0/16,10.6.84.254,lan"] is changed ...

Was the initial value "lan,10.6.0.0/16,10.6.84.254,lan"?

The first item (lan) should be true, like value in the compose file:
FTLCONF_dns_revServers: "true, ..."

[DL6ER]

after clicking import button in teleporter it shows revServers = ["DOMAIN=lan,10.6.0.0/16,10.6.84.254,lan"]

This suggests an issue with the imported configuration, how does it look like inside the backup file you import?

[t4nki]

well, that depends, this configuration has been working pretty good for years
I can mail you the archive if you'd like, after all nothing is that important in it, and you'll be able to see by yourself...

anyhoo, I've grepped through all the config file in the archive, and I didn't find any reference to DOMAIN=lan so, I guess, either it's somewhere else or it's in the code, or I'm blind as a mole...

[rdwebdesign]

In your original backup file, find setupVars.conf file.

What are the values for this 4 variables?

REV_SERVER=
REV_SERVER_CIDR=
REV_SERVER_TARGET=
REV_SERVER_DOMAIN=

[t4nki]

alright, I'm blind as a mole (or drunk, who knows), here's the content of setupVars.conf

REV_SERVER=true
REV_SERVER_DOMAIN=lan
REV_SERVER_TARGET=10.6.84.254
REV_SERVER_CIDR=10.6.0.0/16

notice it matches with the parameters you can find in my ansible snippet available in my first post

EDIT : here's the ansible part for v5 :

- name: Déploiement de PiHole
  containers.podman.podman_container:
    name: pihole
    image: docker.io/pihole/pihole:latest
    label:
      io.containers.autoupdate=registry
      PODMAN_SYSTEMD_UNIT=pod_infra.service
      diun.enable=true
    env:
      DNSMASQ_LISTENING: 'single'
      DNSSEC: 'true'
      DNS_BOGUS_PRIV: 'true'
      DNS_FQDN_REQUIRED: 'true'
      DNSMASQ_USER: pihole
      FTLCONF_LOCAL_IPV4: '{{ ansible_default_ipv4.address }}'
      FTLCONF_PIHOLE_PTR: 'HOSTNAMEFQDN'
      IPv6: 'false'
      PIHOLE_DNS_: '127.0.0.1#5054'
      PIHOLE_DOMAIN: '{{ ansible_domain }}'
      REV_SERVER: 'true'
      REV_SERVER_CIDR: "{{ ansible_default_ipv4.address.split('.')[0:2] | join('.') }}.0.0/16"
      REV_SERVER_DOMAIN: '{{ ansible_domain }}'
      REV_SERVER_TARGET: '{{ ansible_default_ipv4.gateway }}'
      TEMPERATURE_UNIT: 'c'
      TZ: 'Europe/Paris'
      VIRTUAL_HOST: 'pihole.{{ ansible_fqdn }}'
      WEBPASSWORD: '{{ vault_pihole_passwd }}'
      WEBTHEME: 'default-dark'
      WEBUIBOXEDLAYOUT: 'boxed'
      WEB_PORT: '8053'
    volumes:
      - '/srv/pihole/etc-pihole/:/etc/pihole/'
      - '/srv/pihole/etc-dnsmasq.d/:/etc/dnsmasq.d/'
      - '/srv/home/home.html:/var/www/html/admin/home.html'
      - '/srv/ssl/ca.crt:/var/www/html/admin/ca.crt'
    state: present
    restart_policy: "no"
    pod: "infra"
    log_driver: json-file
    log_opt: path=/var/log/containers/pihole.json
    healthcheck_start_period: 1m
    healthcheck_interval: 2m
    healthcheck_retries: 5
    healthcheck_timeout: 1m
    dns: 1.1.1.1

[DL6ER]

Thanks for the additional input, I see now where the bug is - we are using a wrong (intermediate) variable which ends up to contain something different than the expected active boolean at the time of creating the final string. This particular case would have been caught by pi-hole/FTL#1773 but this PR is still awaiting review and not yet active.

This will be fixed by pi-hole/FTL#1901

[t4nki]

Thanks
I saw your PR, glad I could help on this matter, I will test as soon as it is merged

[t4nki]

Hi,

Just updated, and tested the import function, everything works as intended

Thanks for the hard work 👍