Comments (4)
The forum post was about capital letters being rejected, we fixed this.
It is validating domains I have entered months ago and saying they are wrong
The issue you are reporting is about a TLD with a length of one whereas the minimum enforced length is 2:
FTL/src/tools/gravity-parseList.c
Lines 97 to 101 in 91d8738
following https://data.iana.org/TLD/tlds-alpha-by-domain.txt which does not list a single one-character TLD.
However, I do agree with you that users may define such TLDs locally so we should relax this as well. Nonetheless, I want to advise against using TLDs that are not defined in the wild for you private use. Imagine they get defined at some point in the future and suddenly some of your internal configurations become problematic. This threat is not hypothetical as we have seen more recently where a malicious party has registered fritz.box
where this is the host name of a lot of popular routers out in the wild.
from ftl.
Also, looking at the title of this PR:
dns.hosts[0]: invalid hostname
will have shown you where to look. It means that the zeroth element was causing the validation issue.
from ftl.
The forum post was about capital letters being rejected, we fixed this.
yes that is how I was able to say it is unrelated
This issue did not occur until I updated yesterday. Last time I updated was a month ago or so
will have shown you where to look. It means that the zeroth element was causing the validation issue.
So I should have fixed it?
However, I do agree with you that users may define such TLDs locally so we should relax this as well. Nonetheless, I want to advise against using TLDs that are not defined in the wild for you private use. Imagine they get defined at some point in the future and suddenly some of your internal configurations become problematic. This threat is not hypothetical as we have seen more recently where a malicious party has registered fritz.box where this is the host name of a lot of popular routers out in the wild.
corporate infrastructure will probably never not have random domains with 1 letters
This threat is not hypothetical as we have seen more recently where a malicious party has registered fritz.box where this is the host name of a lot of popular routers out in the wild.
That's good they did that, routers should stop with having names at all.
I'd be glad if they actually made single letter TLDs but I doubt it
and even more glad if they took away the period like it used to be and just have names. but I guarantee that one won't happen lol
from ftl.
So I should have fixed it?
No, I mean you could have found it more easily. We still agreed on that this is worth changing. The one-letter TLD validation has been merged and this won't happen again so I'll code this ticket.
from ftl.
Related Issues (20)
- debug.api help text needs another description HOT 1
- FTL Crash HOT 4
- Unable to build FTL from source HOT 9
- app password not working in v6 HOT 7
- [Pi-hole V6] Ftl crash because of database? HOT 10
- [Beta V6] FTL-Checksum error? HOT 4
- Compilation failure with GCC 14 HOT 7
- v6 Seg fault crash on first startup macOS M2 HOT 14
- Pihole-FTL v6 crash when ipv6 disabled and ipv6 dns given. HOT 2
- crash on internet outage HOT 6
- v6: documentation on PUT /clients/ is not complete HOT 8
- DHCP server is configured with incorrect netmask HOT 8
- Pihole is not installing update HOT 6
- Overzealous inline opitimizations? HOT 7
- FTL crashes when activating DHCP server HOT 6
- dev: webserver doesn't properly detect mbedtls dependency HOT 5
- PTR requests not being generated for local clients HOT 26
- Client ipv6 hostnames is not resolving and not being stored in FTL database HOT 5
- Obsolete MAC Vendor DB Script HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ftl.