ph5tomsAPI not handling wildcards correctly

[pic-iris]

ph5tomsAPI not handling wildcards correctly

[derick-hess]

I'll have this fixed soon. Working on it now.

[nick-falco]

Okay thanks. I think shotline and shotid should also accept wildcards.

Just FYI, I can expand most of the wildcards in the web handler, but cannot handle shot-ids and shotlines since the ph5toexml.py program can currently only return all event info for one network. Eventually I think we will want to change the ph5toexml.py program to accept additional query arguments. Then I could expand all wildcards in a list of requests in the handler code and remove overlapping/duplicate requests, in order to add support for HTTP POST for the by Shot request type. This is what I do currently for the FDSN request type.

[derick-hess]

shotid will be easy to accept wildcards, shotline I'll have to work on a bit since you can only have a maximum of one shotline per request and wildcards could match multiple shotlines.

[nick-falco]

In that case maybe we only support wildcards for shotid and not shotline. Do you think supporting wildcards for shotlines would be a useful feature?

[derick-hess]

What I'm going to do now is push code that fixes the array, station, and channel wildcards sicne that is done.

I think we should definitely support wildcards for shotlines and shotids as well as requesting multiple shotlines. I can fix this but it will take substantially more coding and probably more time than I have today to fix those wildcards and add the the ability for multiple shotlines. I will work on this and try to get that pushed by the end of the weekend.

[nick-falco]

Okay that sounds good. Don't worry about working on it over the holiday weekend unless you want to. The FDSN request type still works fine since I expand wildcards in the web handler as I described above. I would say that proper error handling is equally, if not more, important as supporting wildcards for shotid and shotline.

[nick-falco]

Can you add wildcard support for component-id easily to ph5tomsAPI.py?

[derick-hess]

Yeah I can add that no problem.

[nick-falco]

As long as we are updating ph5tomsAPI could we also change the eventnumbers parameter in the constructor to take a List instead of a comma separated String so that it matches the other input parameters?

i.e. eventnumbers="" would be changed to eventnumbers=[] here:
https://github.com/PIC-IRIS/PH5/blob/master/webservices/ph5tomsAPI.py#L99

Update:
@derick-hess
Additionally, it looks like component, station, channel, doy_keep, and station_id are currently defaulting to empty Lists in the constructor, but are still treated like comma separated Strings in the code. For example, if you pass a List of stations (e.g. ['1001','1002']) to the station parameter, it will break on line 352 when it tries to split the List like a comma separated string.

e.g.

  File "ph5tomsAPI.py", line 352, in create_cut_list
    sta_patterns = self.station.split(',')
AttributeError: 'list' object has no attribute 'split'

[derick-hess]

i'll work on fixing all of those.

[nick-falco]

Thanks for pushing your fixes @derick-hess. All of the changes you made seem to be good, so I'm closing this issue.