Turning LoraStackLoader switch to off has no effect

[picturesonpictures]

Turning LoraStackLoader switch to off has no effect

[ryancom16]

Is it because switch can have possible values "off" and "on" https://github.com/picturesonpictures/comfy_PoP/blob/main/LoraStackLoader10_PoP.py#L17

but is being evaluated against "None" ?
https://github.com/picturesonpictures/comfy_PoP/blob/main/LoraStackLoader10_PoP.py#L57

[ryancom16]

Confirmed working if you change the following
if switch == 'None' or lora_name is None:
to
if switch == 'Off' or lora_name is None:

Will need to be updated here as well.
https://github.com/picturesonpictures/comfy_PoP/blob/main/LoraStackLoader_PoP.py#L45

[picturesonpictures]

Thanks,

Confirmed working if you change the following if switch == 'None' or lora_name is None: to if switch == 'Off' or lora_name is None:

Will need to be updated here as well. https://github.com/picturesonpictures/comfy_PoP/blob/main/LoraStackLoader_PoP.py#L45

Thanks! Doing my best with these things. I'll have it fixed momentarily. Please let me know if you have any other issues that you believe need attention.

[picturesonpictures]

Alright, the on/off switches should be good to go now. I tested them out and they're doing what should now. Again, I really appreciate you taking the time to let me know. if you ever have any other issues, ideas, etc, please don't hesitate to let me know.