Comments (5)
Hey Max!
Thanks a lot for reaching out, and for looking into this. I tested this type of flow against SQL Server this morning and I got the exact same result, as you suspected. In reverting to 6.2.0 (pre-taskbuilder removal) everything was kosher.
I just added an internal copy of the widely accepted task builder and pushed it out to nuget (6.2.4). More importantly, I added a test for this specific case to ensure any changes we make going forward.
from donald.
Wow super efficient :)
Thanks for the fix
from donald.
My pleasure!
I've had a sudden change of heart though about the implementation. I think it's likely a better idea to take an explicit dependency on say Ply for example.
I think this way we get all the patches the Nino pushes out, and it makes it more clear to consumers what this thing depends on.
Thoughts?
from donald.
Yep taking the Ply lib as dependency is better to keep up to date. Once F# 6 is out we may take advantage of the new task builder from core library :)
Only downside that I could see is that Ply is not the only task builder implementation outside. But on the other hand it's the most popular. Giraffe made the switch some times ago, I don't know what you are using for Falco
from donald.
Thanks again for bringing this to my attention Max.
Closing since adding Ply to deps.
from donald.
Related Issues (20)
- GetDateTimeOffset Signature is string -> DateTime HOT 1
- Unable to execute query without a transaction HOT 6
- Add a wrapper around ExecuteScalar HOT 6
- TransactionBuilder HOT 9
- CommandBehavior.SequentialAccess causes error with SqlHydra readers HOT 5
- Cast exception when reading DateTimeOffset with System.Data.SqlClient HOT 4
- [Help] How to parse results with sequential access? HOT 2
- v.7.0.0 HOT 9
- FsDto lib review HOT 2
- Who is @dysme on the landing page? HOT 3
- CancellationToken support
- Support of transaction in newCommand in Fluent syntax HOT 3
- Getting error while using Db.Async.query method HOT 6
- Require help on query HOT 7
- Support or Transition to Microsoft.Data.SqlClient HOT 3
- SQLite: What SQL Type should I choose for a JSON column? HOT 2
- Possible issue with Db.Async.exec throwing instead of returning a Result HOT 1
- How to deal with DB enums in Donald? HOT 1
- Doc comment error for newSproc HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from donald.