Giter Site home page Giter Site logo

Comments (5)

pimbrouwers avatar pimbrouwers commented on June 24, 2024

Hey Max!

Thanks a lot for reaching out, and for looking into this. I tested this type of flow against SQL Server this morning and I got the exact same result, as you suspected. In reverting to 6.2.0 (pre-taskbuilder removal) everything was kosher.

I just added an internal copy of the widely accepted task builder and pushed it out to nuget (6.2.4). More importantly, I added a test for this specific case to ensure any changes we make going forward.

from donald.

MaxDeg avatar MaxDeg commented on June 24, 2024

Wow super efficient :)
Thanks for the fix

from donald.

pimbrouwers avatar pimbrouwers commented on June 24, 2024

My pleasure!

I've had a sudden change of heart though about the implementation. I think it's likely a better idea to take an explicit dependency on say Ply for example.

I think this way we get all the patches the Nino pushes out, and it makes it more clear to consumers what this thing depends on.

Thoughts?

from donald.

MaxDeg avatar MaxDeg commented on June 24, 2024

Yep taking the Ply lib as dependency is better to keep up to date. Once F# 6 is out we may take advantage of the new task builder from core library :)
Only downside that I could see is that Ply is not the only task builder implementation outside. But on the other hand it's the most popular. Giraffe made the switch some times ago, I don't know what you are using for Falco

from donald.

pimbrouwers avatar pimbrouwers commented on June 24, 2024

Thanks again for bringing this to my attention Max.

Closing since adding Ply to deps.

from donald.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.