Comments (3)
@fashxp for varnish tags we don't need to manipulate existing/system tags. We just need to add additional tags.
You can use the prepare response event (as it currently is) to pass the additional tags to the Cache:save $tags. But depending on the setup, the tags header can be X-Cache-Tags
, Surrogate-Key
or Cache-Tag
. And you would need to also consider that sometimes there will be multiple cache tags to allow more tags than the 4kb limit. So it's not so easy to get the tags header value to set the $tags.
The best solution would be to allow the prepare response event
to set some tags, and then set the $tags = array_merge($event->getTags(), $tags)
to merge them with the Pimcore system tags.
from pimcore.
Would you also need to remove the default tags output
and output_lifetime
. Because I'm not too sure if we should allow manipulating these too as they are crucial for internal Pimcore cache handling and fiddling around with them might have unwanted side effects.
When it is just about adding additional events it might be enough to allow to add additional tags via the prepare response event, wdyt?
from pimcore.
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.
from pimcore.
Related Issues (20)
- [Bug]: Unable to generate thumbnail in ORIGINAL format
- [Improvement]: BSI compliant password standards HOT 2
- [Feature]: Workflow's globalActions is missing settings
- [Bug]: TinyMCE cannot be configured as documented because some plugins are missing HOT 4
- Custom View not saving the path using the Perspective Editor
- [Improvement]: Slow loading in mapping tap in data-importer when have a lot of attributes mapped
- [Improvement]: Add admin async loading to reverseObjectRelation
- [Bug]: object cache is not getting generated automatically HOT 1
- Imagick Alternative for Image Transformations / Thumbnails HOT 7
- [Bug]: published field show incorect value when preview a version created in pimcore 10
- [Improvement]: Refine `phpoffice/phpspreadsheet` requirement
- [Bug]: Pimcore workflow permissions which we give in yaml file is conflicting with keybindings HOT 1
- Upgrade to doctrine V4
- [Bug]: CleanupBrickTask does not handle inial lower case letter in bricks and fieldcollections
- [Feature]: allow forbidding uploading duplicate assets
- [Improvement]: further introduce JSON-types for non-primitive data
- [Bug]: `MyDataObject::getByField($value, limit: 1)` doesn't return a single object (when named parameters are used)
- [Bug]: Custom view broke tree displaying
- [Improvement]: Change condition in query for custom view children in tree structure HOT 1
- PhpStan Version Upgrade June
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pimcore.