Giter Site home page Giter Site logo

Comments (3)

mlumia avatar mlumia commented on June 2, 2024 1

@fashxp for varnish tags we don't need to manipulate existing/system tags. We just need to add additional tags.

You can use the prepare response event (as it currently is) to pass the additional tags to the Cache:save $tags. But depending on the setup, the tags header can be X-Cache-Tags, Surrogate-Key or Cache-Tag. And you would need to also consider that sometimes there will be multiple cache tags to allow more tags than the 4kb limit. So it's not so easy to get the tags header value to set the $tags.

The best solution would be to allow the prepare response event to set some tags, and then set the $tags = array_merge($event->getTags(), $tags) to merge them with the Pimcore system tags.

from pimcore.

fashxp avatar fashxp commented on June 2, 2024

Would you also need to remove the default tags outputand output_lifetime. Because I'm not too sure if we should allow manipulating these too as they are crucial for internal Pimcore cache handling and fiddling around with them might have unwanted side effects.
When it is just about adding additional events it might be enough to allow to add additional tags via the prepare response event, wdyt?

from pimcore.

github-actions avatar github-actions commented on June 2, 2024

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

from pimcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.