Giter Site home page Giter Site logo

Comments (2)

yariksheptykin avatar yariksheptykin commented on August 30, 2024 2

Thanks for bringing up this discussion @passioneight . I also believe that docker-compose could benefit from some redesign.

I suggest we drop php-fpm-debug completely and instead parametrize php-fpm service to use either -debug or no-debug image flavor. This would also eliminate the need to "balance" between php-fpm-debug and php-fpm for nginx, which would simplify the config a bit. Triggering xdebug should better be implemented with xdebug means / triggers.

To adjust what ports DB-container binds to per environment it is indeed better to use docker-compose.override.yaml. We can create an example .override.yaml.dist in this repo to demonstrate some common customization. However, as this file is supposed to contain individual customizations I don't think we should add this file to the skeleton.

I think that trying to make this docker-compose.yaml staging- or production-ready is a good idea overall. It is, however, dangerous at the same time. This docker-compose.yaml should not be used as is in staging or production environments. Staging should align as close as possible with production. In most of the cases you would not use single-node compose based setups in production. I see the best fit for this docker-compose.yaml file is to set up production-near environment locally.

from skeleton.

jdreesen avatar jdreesen commented on August 30, 2024 2

I suggest we drop php-fpm-debug completely and instead parametrize php-fpm service to use either -debug or no-debug image flavor. This would also eliminate the need to "balance" between php-fpm-debug and php-fpm for nginx, which would simplify the config a bit. Triggering xdebug should better be implemented with xdebug means / triggers.

I just created a PR which moves in this direction: #99

from skeleton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.