Comments (2)
Thanks for bringing up this discussion @passioneight . I also believe that docker-compose
could benefit from some redesign.
I suggest we drop php-fpm-debug
completely and instead parametrize php-fpm service to use either -debug
or no-debug image flavor. This would also eliminate the need to "balance" between php-fpm-debug
and php-fpm
for nginx, which would simplify the config a bit. Triggering xdebug should better be implemented with xdebug means / triggers.
To adjust what ports DB-container binds to per environment it is indeed better to use docker-compose.override.yaml. We can create an example .override.yaml.dist
in this repo to demonstrate some common customization. However, as this file is supposed to contain individual customizations I don't think we should add this file to the skeleton.
I think that trying to make this docker-compose.yaml staging- or production-ready is a good idea overall. It is, however, dangerous at the same time. This docker-compose.yaml should not be used as is in staging or production environments. Staging should align as close as possible with production. In most of the cases you would not use single-node compose based setups in production. I see the best fit for this docker-compose.yaml file is to set up production-near environment locally.
from skeleton.
I suggest we drop php-fpm-debug completely and instead parametrize php-fpm service to use either -debug or no-debug image flavor. This would also eliminate the need to "balance" between php-fpm-debug and php-fpm for nginx, which would simplify the config a bit. Triggering xdebug should better be implemented with xdebug means / triggers.
I just created a PR which moves in this direction: #99
from skeleton.
Related Issues (20)
- [Bug]: Skeleton now requires unstable pimcore version HOT 8
- [Task] Add @param and @return php doc types to non-internal public and protected methods HOT 1
- Composer: do not run migrations automatically on post update
- [Feature]: support Caddy as a reverse proxy HOT 1
- [Task]: Remove o_ prefix for data object properties and database columns HOT 1
- twig_matches issue
- [Bug]: Getting error when trying to install Pimcore skeleton v10.5.13 HOT 8
- [Improvement] activate PimcoreSimpleBackendSearchBundle by default
- [Improvement]: Permissions "var/log/dev.log" HOT 3
- [Improvement]: Implement a separate docker compose file for codeception for more clarity HOT 4
- [Bug]: Docker install fails in different ways HOT 4
- Enable AdminBundle: require pimcore/admin-ui-classic-bundle HOT 1
- [Bug]: Supervisor conf doesn't contain all queues HOT 1
- [Improvement]: Check if multiple workers are necessary
- [Bug]: Tests in "Readme" not working HOT 7
- [Bug]: Admin panel does not work HOT 2
- [Bug]: Duplicate extension "avif", content type HOT 1
- [Feature]: Documents Editable HOT 1
- [Feature]: Skeleton Repository for SAAS application HOT 2
- [Improvement]: Use port 3307 instead of 3306 in docker-compose.yaml HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skeleton.