Having problem on django-mailer on using with djoser

[pawanpaudel93]

Having problem on django-mailer on using with djoser

[spookylukey]

I'm going to re-open this, for the sake of anyone searching for the issue, although I don't intend to do anything about it in django-mailer itself.

[spookylukey]

It's not at all clear to me that this is a bug in django-mailer. It rather looks like a bug in "templated_mail" due to it creating EmailMessage objects in some non standard way that means they can't be pickled.

If you can provide a reduced test case that shows an issue in django-mailer that would be helpful.

[pawanpaudel93]

@spookylukey thanks for replying.

This is what Djoser uses django-templated-mail and It works only when I remove the request https://github.com/pawanpaudel93/django-mailer/blob/master/src/mailer/models.py#L94 while pickling the email on django-mailer. So, there is a problem picking the request. Can you take a look at why the pickling error is occurring ?? @spookylukey

[spookylukey]

OK, it's like I thought. templated_mail is adding extra stuff to the EmailMessage instances, things that can't be pickled (like HttpRequest objects). django-mailer needs to pickle the EmailMessage object, so that is incompatible.

See https://github.com/sunscrapers/django-templated-mail/blob/65e5a34f69d50d4d1b6acdd337f9efcc44b32fae/templated_mail/mail.py#L18

You need to file a bug with templated_mail and see if there is a way for them to do it without adding that attribute. There is no reason for EmailMessage objects to have the request attached to them, that's sounds like a bad design decision to me. An email class shouldn't have access to HttpRequest objects, it's a layering violation, because sending email has got nothing to do with processing HTTP requests. You should rather separate those activities - you should have a function/class that prepares the content of the email (which may use request if you really want), and then passes it on to the EmailMessage constructor. There is no need to subclass EmailMessage in this case.

[pawanpaudel93]

@spookylukey Thank you very much for your time and help and also thanks for the great Django app.

[spookylukey]

See sunscrapers/django-templated-mail#29 which may resolve the issue.