Comments (8)
Thanks @zerowebcorp ! We've reviewed your input, and given the relatively minor change that will be required, we should be able to squeeze this in for our next release cycle late next week or early the following.
I'll keep you posted in this issue.
from helm-charts.
@zerowebcorp in researching, it seems our charts support the following that might not require us to make changes. I tested this and I think it meets your needs.
global:
envs:
PING_IDENTITY_ACCEPT_EULA: "YES"
#############################################################
# pingfederate-admin values
#############################################################
pingfederate-admin:
enabled: true
envs:
SERVER_PROFILE_URL: https://github.com/pingidentity/pingidentity-server-profiles.git
SERVER_PROFILE_PATH: getting-started/pingfederate
#############################################################
# pingfederate-engine values
#############################################################
pingfederate-engine:
enabled: true
envs:
SERVER_PROFILE_URL: https://github.com/pingidentity/pingidentity-server-profiles.git
SERVER_PROFILE_PATH: getting-started/pingfederate
workload:
annotations:
backup.velero.io/backup-volumes: data
and what rendered was:
# Source: ping-devops/templates/pingfederate-engine/workload.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/instance: test
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: pingfederate-engine
helm.sh/chart: ping-devops-0.10.1
name: test-pingfederate-engine
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/instance: test
app.kubernetes.io/name: pingfederate-engine
strategy:
<stuff here>
template:
metadata:
annotations:
backup.velero.io/backup-volumes: data
checksum/config: e14182d42c4cbf0a29371f868ecdd12e8520dc2256de1b66a472b1ef77a808aa
Would you mind giving that a go and see if it works for you?
from helm-charts.
it is the workload.annotations
block that our charts know how to handle
from helm-charts.
@zerowebcorp We are planning a chart release in the next day or so, and if the workload.annotations block doesn't meet your needs, we can get this in, but we need your feedback to know for sure.
Thanks!
from helm-charts.
@PingDavidR Just tested this by adding the annotation under the pingfederate-admin block and it gets added. This satisfies my requirement.
However, since this works for Deployment
and not for Statefulset
this could be classified as a bug. I would expect that anything under global
would be applied for all the components ( pingfederate-admin/pingfederate-runtime) and don't have to specify them individually. Would be great to have this fixed for both the workload type.
from helm-charts.
aha! I wasn't as clear as I thought, @zerowebcorp: Try this - this should do what I think you are looking for - specify workload at the global level:
global:
envs:
PING_IDENTITY_ACCEPT_EULA: "YES"
workload:
annotations:
backup.velero.io/backup-volumes: data
This will attach the annotation to SS and Deployment both, at the Pod level
from helm-charts.
ohk, thank you for clarifying. Adding the annotations under global.workload
instead of global
works.
from helm-charts.
Glad to hear it! And thanks again for using our charts!
from helm-charts.
Related Issues (20)
- Update default global.image.tag to 2112
- Enabling Remote Based Access Control(RBAC) in PingFederate Helm Charts HOT 2
- Update default global.image.tag to 2201
- Api Version conditional logic not working on ingresss. HOT 1
- Use existing service account for rbac doesn't work HOT 1
- Unable to download Helm Chart 0.9.7 from terraform HOT 1
- pingfederate admin is not recognizing the datastore HOT 1
- how to work with topologySpreadConstraints HOT 5
- volumeMount: mountPath value considered as a directory HOT 1
- Pingfederate StatefulSet persistentvolume creation HOT 1
- PD ldaps:// url not working for SSL encryption HOT 1
- Don't Set Deployment Replicas When Autoscaling HOT 1
- Universally Handle SemVer Pre-Release Versions for EKS HOT 1
- SemVer selecting autoscaling/v2beta2 rather than autoscaling/v2 HOT 5
- Unable to annotate PVCs HOT 8
- ingress.class deprecated - Missing support for ingressClassName HOT 3
- upgrade to version 10 HOT 4
- Persistent Volume is being created even through enabled=false is set. HOT 1
- Update the pingtoolkit image in PF HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-charts.