Giter Site home page Giter Site logo

Updating for v9 about json-colorizer HOT 14 CLOSED

Ranieri93 avatar Ranieri93 commented on May 27, 2024
Updating for v9

from json-colorizer.

Comments (14)

jsumners avatar jsumners commented on May 27, 2024 1

I think so.

from json-colorizer.

jsumners avatar jsumners commented on May 27, 2024 1

Thank you @Ranieri93.

from json-colorizer.

jsumners avatar jsumners commented on May 27, 2024

Do you have in mind a range of dates to inspect data coming from npm-stat.com?

The default is one year to date, and I think that is sufficient. This package shows very limited usage -- https://npm-stat.com/charts.html?package=%40pinojs%2Fjson-colorizer&from=2022-08-27&to=2023-08-27

I also don't see any of the Pino packages depending on this one -- https://www.npmjs.com/package/@pinojs/json-colorizer?activeTab=dependents

From the commit history, it looks like @capaj created this fork and contributed it to the org. I'd like to hear if they remember the reasoning, and if they think it should continue to exist.

I'd also like to hear @mcollina's opinion.

My opinion is that this should be decommissioned (archived in GitHub) and marked as deprecated on npm.

from json-colorizer.

capaj avatar capaj commented on May 27, 2024

I changed dependency from chalk to colorette because it is faster and then moved the repo to pinojs org.

pinojs/pino-pretty#229 (comment)

if they think it should continue to exist.

I am not sure what you are talking about here. Can you specify?

from json-colorizer.

jsumners avatar jsumners commented on May 27, 2024

I am not sure what you are talking about here. Can you specify?

As shown above, it is not currently used by any Pino project. Given the lack of maintenance of this package, and the lack of usage in other org projects, I think we are better off reducing our burden.

from json-colorizer.

capaj avatar capaj commented on May 27, 2024

Oh right. Feel free to transfer the package back to me or archive it.
I find it useful and I use it for logging on my development machine on projects I work on daily basis. I would most likely find time to add esm modules and update dependencies.

from json-colorizer.

Ranieri93 avatar Ranieri93 commented on May 27, 2024

@jsumners and @capaj thank you so much! Then we'll consider this as deprecated and I'll move to the next one

from json-colorizer.

jsumners avatar jsumners commented on May 27, 2024

@Ranieri93 we haven't heard @mcollina's opinion yet.

from json-colorizer.

Ranieri93 avatar Ranieri93 commented on May 27, 2024

Oh, you're entirely correct! Let's hear @mcollina!

from json-colorizer.

mcollina avatar mcollina commented on May 27, 2024

It would be great if we could have colorized output of JavaScript objects in pino-pretty. However a PR to do that never materialized. I think we should ideally do that instead of archiving/transfering.

from json-colorizer.

jsumners avatar jsumners commented on May 27, 2024

Okay, I have created the next branch https://github.com/pinojs/json-colorizer/tree/next

from json-colorizer.

Ranieri93 avatar Ranieri93 commented on May 27, 2024

Hey @jsumners, I would like to start working on this.
Now I'll pose some questions, presumably even stupid ones. It's my first time so I'm gonna ask you for some patience. 😄

  • Updating dependencies: I assume try to update every package to the latest version and see if tests are still up and running. Do I need anything else?
  • Dropping Node <= 16: Here unfortunately I'm in the dark, could you elaborate a little bit?
  • Updating CI configuration: I see that here we use Travis and that the config file is pretty straight, so I guess won't be hard. Do I need to pay attention to something in particular?
  • Testing suite configuration (tap): Can you elaborate as well? Should I migrate the current framework to tap?
  • Anything else you think is required to achieve this is welcome.

Thank you so much in advance!

from json-colorizer.

jsumners avatar jsumners commented on May 27, 2024
  • Updating dependencies: I assume try to update every package to the latest version and see if tests are still up and running. Do I need anything else?

No, that should be all. The only catch is to make sure we can actually use the latest versions. Some dependencies have shifted to ESM only, and that won't work. Such dependencies would need to be pinned to the latest version that is non-ESM.

  • Dropping Node <= 16: Here unfortunately I'm in the dark, could you elaborate a little bit?

This means removing the CI configuration for any version of Node less than 18. It can also mean going through the code and removing/updating any blocks that specifically tagged as something like "for Node X support".

  • Updating CI configuration: I see that here we use Travis and that the config file is pretty straight, so I guess won't be hard. Do I need to pay attention to something in particular?

I would remove Travis and migrate it to GitHub Actions.

  • Testing suite configuration (tap): Can you elaborate as well? Should I migrate the current framework to tap?

That would be nice in order to keep thing consistent across the org. But it is definitely not a hard requirement.

from json-colorizer.

Ranieri93 avatar Ranieri93 commented on May 27, 2024

Should we consider this as done?

from json-colorizer.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.