Comments (17)
I ended up appending the skill order to the first block if there is an item set, or creating a new one if there isn't. I'm happy with this approach and there's no other way that I can think of, so I'm closing this off.
from legendary-rune-maker.
You wrote PENIS with the item first letters. Now I get it.
from legendary-rune-maker.
I would advocate more for u.gg than blitz.gg at this point (but either is welcome) and you might be able to snag Runebook's implementation as I see someone made a plugin for it that was pulled into their repo.
Thanks again for spending the time that you have on this!
It's so very useful to me and I'd think to others as well but your reddit post seems to have gotten buried.
from legendary-rune-maker.
Same! It saves so much time and is so clean. I admire your code's conventions as well.
Saw the u.gg commit and I'm hyped.
from legendary-rune-maker.
Thanks for your comments! Sorry I haven't been able to answer earlier. I did think about implementing this when I started developing the app but I didn't think it was useful enough. Although if you do think it is, I will try to add it.
from legendary-rune-maker.
I honestly think your app is the best among those with similar features.
Doesn't crash or lag out like the other I tried (Manaflux).
Was bummed when I thought you abandoned it.
The auto-pick/ban features seem to need work if you get back into it, btw. I can add another issue if you want.
Also not sure if blitz.gg has an API but adding that as a provider would be sweet too (again, I'll add new issues just didn't want to spam).
from legendary-rune-maker.
Thanks you, it means a lot. And yeah, some features need some care, like the auto pick stuff.
I'll see what I can do about blitz.gg, it doesn't seem too hard to add.
from legendary-rune-maker.
U.gg does seem like a better alternative, l'll probably end up adding both.
The post did get kinda buried, I may try making another one in the future. I think one of the reasons it got buried was that Riot didn't confirm the legality of it, but that should hopefully be cleared up now given their recent statement.
from legendary-rune-maker.
from legendary-rune-maker.
For sure, it's really fun to develop this, and I use it everyday too.
from legendary-rune-maker.
Last piece of the puzzle here in my opinion. If you can get the providers to send you the skill info and parse it to shorthand for use the in the item group names you have a gem of an app on your hands and reddit will have a field day! I wonder if you can set summoners based on providers?
from legendary-rune-maker.
I can get summoner spell info from most providers, the tricky part would be integrating it as not all providers have item sets, so I'd need to create an item set in the client just for the skills.
from legendary-rune-maker.
Wouldn't be the worst solution, but I see what you're saying. I'll think about this and see if there's anything else I can come up with.
from legendary-rune-maker.
Weird issue here. What's up with the items in the first block? Nice touch putting it in the item set name.
from legendary-rune-maker.
Looks like it appends each time you load the game.
PENIS
PENIS
PENIS
PENIS
😆
Logs:
logs.zip
from legendary-rune-maker.
Should be fixed
from legendary-rune-maker.
Frick
from legendary-rune-maker.
Related Issues (20)
- it always shows not logged in HOT 1
- Auto ban doesn't work HOT 3
- Not logged in
- Program crashes after locking champion
- Draft role detection
- leagueofgraphs supports
- Json Integer too large for Int32 HOT 1
- [Suggestion] Download all builds
- AutoPick dont work
- Not logging in HOT 1
- Incomplete files HOT 3
- Champion.GG item set provider is broken HOT 3
- Unhandled Exception HOT 3
- crash on champio lock HOT 1
- How to run the legendary rune maker? HOT 1
- New error after locking chmpion and setting rune
- Hi, are there plans to fix the program? HOT 3
- source code
- Automatically accept
- Please update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legendary-rune-maker.