Pick Summoners 1.1.0-debug

[sudravirodhin]

Pick Summoners 1.1.0-debug

[pipe01]

All auto picking needs some work

[pipe01]

Okay, so I ended up rewriting some of the logic that activates the auto picking, it should be much more stable.

When loading vs. AI it picked Top even though Fill was set to no champs.

The app will try to select the champion that matches your config the best, i.e. if you have set the fill champion to Akali and the top champ to Sion, Sion will be picked if you play top and Akali will be picked if you are playing in any other lane. It doesn't really matter what the fill champion is as long as you are playing in a lane that does have a champion set (except when the lane champ isn't available, in which case the fill one will be picked).

Support/Bottom are still switched.

When exactly does this happen?

[pipe01]

K I found the cause for the swapping bug, turns out the images were out of order in the UI lol

[pipe01]

Can you send a screenshot of your automation config?

[sudravirodhin]

Yes, contents of a specific file or the actual choices in the GUI?

[pipe01]

Just the GUI will do it.

[sudravirodhin]

Happened again just now:

[pipe01]

Can you download the latest build and try again? I added some logging so that should give me some insight. The log file should be in the logs folder next to the executable. El jue., 29 nov. 2018 4:16, Gregory Adam Conroy <[email protected]> escribió:

…

Happened again just now: [image: image] <https://user-images.githubusercontent.com/3495530/49197017-20e3ef00-f342-11e8-9c65-4f146096e6c3.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADtKicmmP5wsoYV2N7WhYbSlRX81Rbutks5uz1GagaJpZM4Y2vAO> .

[sudravirodhin]

Absolutely. Will update you when I next use it.

[sudravirodhin]

logs.zip
Here are my logs from last night. Not sure if it captured it happening or not.

Will try and deliberately catch it tonight.

[pipe01]

I can see that at some point flash and heal were picked, but I'm unsure if the config was or wasn't properly set then. I added config logging so that should clear things up for next time.

[sudravirodhin]

You got it. I'll use the newest build when I play today.

[sudravirodhin]

logs.zip
Here's today's logs. Some weird bugs:

• When loading vs. AI it picked Top even though Fill was set to no champs.
• When grabbing u.gg rune page it added it to the client right but the UI showed weird choices that didn't match what it uploaded to the client.
• Support/Bottom are still switched. Summoner Spells still pick heal randomly instead of ignite when support. Tried swapping back and forth.

Today's a bad league day (lost promos and almost lost the bot match for win of the day) so the above zip is all I have for today. Hope your games go better than mine.

[pipe01]

I think I'm going to rewrite a lot of code, it's gotten very buggy and complex.

[sudravirodhin]

So ARAM and Co-op games are considered "FILL" then?

As for the bot/sup switch, sometimes it picks the wrong summoners but based on your feedback this might be fixed.

[pipe01]

So ARAM and Co-op games are considered "FILL" then?

Yup

As for the bot/sup switch, sometimes it picks the wrong summoners but based on your feedback this might be fixed.

🤞

[pipe01]

I feel like I'm ready to release the next version, so give it a try and tell me if you find any more bugs.

Also, do you have a Discord?

[sudravirodhin]

Will try it tonight and update you if I find anything. Thanks!

Yes I do have Discord. Sudravirodhin#5048.

[sudravirodhin]

Yikes, getting a run-time exception and I can't even dump. Fresh extract of the latest build.

Screenshot:

[sudravirodhin]

Last working build with fresh start was: 4a9fd8d

Will see if it's a config file problem by overwriting latest debug on top.

[sudravirodhin]

Crashes out with latest commit 606a6be unzipped on top of 4a9fd8d.

Logs here:
logs.zip

[sudravirodhin]

Seems it has to do with the LoginDetector function because when not logged in or without client open it crashes. At least you know where to look now!

[sudravirodhin]

Summoner picking still a bit wonky.

[sudravirodhin]

Looks like it freaks out when the skill isn't applicable for the mode.

[sudravirodhin]

Aha! Remember you asked when that bot/supp switch happens? Look!

[pipe01]

Do you have the logs? Especially for the support-adc swapping. El sáb., 1 dic. 2018 6:32, Gregory Adam Conroy <[email protected]> escribió:

…

Aha! Remember you asked when that bot/supp switch happens? Look! [image: image] <https://user-images.githubusercontent.com/3495530/49324671-74437200-f4e7-11e8-978f-ccc1a262e734.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADtKiefN-JlZw5I9j4jcMs6jH56tsoz0ks5u0hR3gaJpZM4Y2vAO> .

[pipe01]

About the summoner spells, if you choose a spell that isn't available it should just not do anything, isn't that what happened there?

[sudravirodhin]

About the summoner spells, if you choose a spell that isn't available it should just not do anything, isn't that what happened there?

If I chose a spell that wasn't available it freaked out and gave me Clarity and Exhaust.

Here are the logs from last night's sessions.
logs.zip