Comments (3)
I'm negative to change the behavior of the "sound playing" icon on TST tree items.
Behaviors of the sound playing button and "Mute/Unmute Tab" context menu commands on Firefox's native tabs are:
1a. "Mute/Unmute Tab" context menu commands affect to the target tab whether the tab is sound-playing or not.
2a. The sound playing button is shown on a sound playing tab. Clicking on the button mutes the tab, and clicking again unmutes the tab.
3a. On recent versions of Firefox, the button is shown on "ready to play sound" tabs (e.g. YouTube tabs opened in the background) also. Clicking such a "ready to play" button starts playing sound of the tab.
On the other hand, the sound playing button and "Mute/Unmute Tab" context menu commands in TST are:
1b. "Mute/Unmute Tab" context menu commands affect to the target individual tab whether the tab is sound-playing or not. This is compatible to Firefox's native commands.
2b. The sound playing button is shown on a sound playing tab or the parent of a collapsed tree containing sound playing descendant. Clicking on the button mutes the sound playing tab, and clicking again unmutes the tab.
3b. "Ready to play sound" button never appear on TST tabs because Firefox does not expose such a state of tabs to addons via WebExtensions API.
The actual result you saw is from the behavior 2b. It is by design. I think it is most natural behavior of the button on TST's tree because the sound playing button on Firefox's native tabs does not provide ability to mute non-sound-playing tabs.
However I agree that there is demand to mute whole tree. Thus I've added new context menu commands "Mute/Unmute this Tree" and "Mute/Unmute Descendants". I hope these commands help you.
from treestyletab.
Thank you, yes, that added context menu will do the trick.
Just to explain my original reasoning (and why I still think that the behaviour is bug-alike, but certainly not a priority to fix): I think the discrepancy in expectation comes from the fact that you can mute a tab with Ctrl-m at all times, so I never use the actual button, and I was confused when two actions that have the same result in vanilla (button click / C-m both mute a tab) did not have the same result in TST.
from treestyletab.
Thank you for explanation!
Ctrl-M is processed by Firefox itself and it corresponds to the "Mute/Unmute Tab" command in the context menu. When you mainly see TST's sidebar, it works like as "Mute/Unmute the active individual tab". I also introduced keyboard shortcut slots for newly added commands so using them instead of Ctrl-M may reduce confusions like yours.
from treestyletab.
Related Issues (20)
- new tab from non-existing tab HOT 1
- [Bug] "Undefined" entries at bottom of sidebar HOT 2
- [Bug] Switches tabs with certain sequences of keypresses/mouse clicks
- [Bug] TST Tab Search extension no longer works correctly with TST HOT 7
- [Bug] Drag and droping outside of sidebar not working when maximised HOT 1
- [Enhancement] toggle expand/collapse function HOT 2
- [Enhancement] Drag parent onto child HOT 2
- TST tab list blank when moving firefox window to different monitor (Error location found) HOT 3
- Tab counter is broken in latest update HOT 3
- [Feature request] (Sub Tabs/Trees selection Shift+Click is pressed) HOT 2
- [Enhancement] Drag N' Drop, maintain folded state HOT 3
- [Enhancement] Auto show and hide TST when needed HOT 2
- [Bug] Unable to zoom sidebar on MacOS HOT 1
- [Enhancement] Option to re-open browser with all tabs Collapsed HOT 2
- Feature request: Add option to unload tabs HOT 5
- [Bug] tab appearance in incognito tabs seems broken HOT 3
- [Enhancement] (Container inheritance for child tabs) HOT 1
- [Enhancement] Review terminology used in locales HOT 1
- [Bug] Cannot scroll the sidebar with latest nightlies HOT 7
- [Enhancement] Prevent Automatic Collapse/Expand to keep all tab depths/tab titles in view HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from treestyletab.