Giter Site home page Giter Site logo

Comments (5)

piroor avatar piroor commented on July 3, 2024

Firefox does not allow WebExtensions addons to show arbitrary popup, so we only have three choices:

  • A: Show preview popup inside the sidebar.
    • Pros: Easy to implement, secure.
    • Cons: Preview popup over vertical tabs will annoying (because it blocks access to tabs covered by it.)
  • B: Embed preview popup inside the contents (the Web page you are currently see.)
    • Pros: Popup won't cover vertical tabs so useful.
    • Cons: Insecure. The active Web page can know you are using TST by tracking DOM events around elements embedded to the Web page by TST.
  • C: Show preview popup as a regular window (like windows opened by window.open())
    • Pros: Popup won't cover vertical tabs so useful. Easy to implement, secure.
    • Cons: Visually annoying. The preview popup will have its own window decorations including titlebar.

All possible plans have serious cons, so currently I'm negative to implement preview popup from these choices.

Waterfox Sidebar (it is an extended version of TST) supports preview popup with native appearance. Waterfox itself is currently based on Firefox 115, so you'll see preview popup for tabs sidebar after its base version is updated to 128.

from treestyletab.

bege10 avatar bege10 commented on July 3, 2024

Do we talk about the same things?
I don't mean the thumbnails. That is an option in the settings page of Firefox independent from the normal or card view of the tooltip.
Because the tooltip without thumbnail looks the same with or without TST when the mentioned pref is set to false I thought it might be possible to have it look the same with and without TST with this pref set to true.
Screenshot_348

from treestyletab.

piroor avatar piroor commented on July 3, 2024

Oh sorry I misunderstood that you meant both browser.tabs.cardPreview.enabled and browser.tabs.cardPreview.showThumbnails are true. I've realized that you meant browser.tabs.cardPreview.enabled=true and browser.tabs.cardPreview.showThumbnails=false case.

I've created mock images for A, B and C.

A:
image

B:
image

C:
image

from treestyletab.

piroor avatar piroor commented on July 3, 2024

As those mocks described, such a rich popup has problems regardless it has a preview image or doesn't. This is the reason why I'm negative to simulate "browser.tabs.cardPreview.enabled" by TST.

from treestyletab.

bege10 avatar bege10 commented on July 3, 2024

I wouldn't mind A without thumbnail but I understand your opinion.
Am I correct that the normal tool tip in TST is from Firefox and not simulated by TST? And that Firefox changes the tool tips to card view only for the normal Firefox tabs? So the only way to have card view tool tips in TST is by simulating them with extra code?

And thank you for this valuable add-on!

from treestyletab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.