Comments (4)
I've confirmed this behavior. Looking into it now.
from licensefinder.
So, this is happening because the rails_12factor
gem v0.0.2 has the following gemspec packaged with it:
# -*- encoding: utf-8 -*-
require File.expand_path('../lib/rails_12factor/version', __FILE__)
Gem::Specification.new do |gem|
gem.authors = ["Richard Schneeman", "Terence Lee"]
gem.email = ["[email protected]", "[email protected]"]
gem.description = %q{Run Rails the 12factor way}
gem.summary = %q{ Following best practices from http://12factor.net run a maintainable, clean, and scalable app on Rails}
gem.homepage = "https://github.com/heroku/rails_12factor"
gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
gem.files = `git ls-files`.split("\n")
gem.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
gem.name = "rails_12factor"
gem.require_paths = ["lib"]
gem.version = Rails12factor::VERSION
gem.license = 'LICENSE'
gem.add_dependency "rails_serve_static_assets"
gem.add_dependency "rails_stdout_logging"
end
the key point being this line:
gem.license = 'LICENSE'
and the file named LICENSE
packaged in the gem is not MIT.
@mainej, what behavior do you expect from LicenseFinder under these circumstances?
(In the meantime, it looks like the licensing was changed for rails_12factor
in this pull request, which was merged in May 2014. However, the gem has not been re-released since June 2013.
@schneems, would you consider pushing a new gem with updated license info?
from licensefinder.
I'm going to close this issues. @mainej, if you'd like to start a conversation about how, generally, LicenseFinder should handle inconsistent license metadata and/or references to unknown or non-existent licenses, I'd love to start that under a new issue. But I think there's nothing actionable around this issue right now.
from licensefinder.
@flavorjones agreed, this should be closed. Thanks for figuring out the source of the problem and requesting the rubygems version bump. In general gem/package metadata is much more reliable than any other heuristic license_finder uses. I think it's better to keep LF simple and accept that this sort of thing happens occasionally than to try to make LF handle every possible inconsistency.
from licensefinder.
Related Issues (20)
- Scanning for Flutter dependency licenses is broken HOT 3
- SPM local packages HOT 2
- Pathname with spaces is not properly escaped HOT 2
- LicenseFinder hangs / stuck with Electron and Yarn HOT 3
- Unable to parse requirements file containing arguments to pip HOT 1
- Asterisk shouldn't affect license permission HOT 1
- Parse and validate valid license expressions HOT 2
- Don't get licenses when running docker in Azure Pipeline HOT 1
- False Negative on AGPL HOT 1
- ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console... (RuntimeError) HOT 1
- Breaking change after 7.2.0 ? HOT 4
- nuget <licenseUrl> is deprecated HOT 1
- [BUG] 'permitted_licenses add' not working properly for all licenses using spdx-id format. LGPL and Python for sure. HOT 2
- docker image has EOL python 3 version HOT 2
- Gradle command issue HOT 2
- Add possibility to permit / restrict licenses based on regex HOT 1
- Yarn 2 does not work for recursive projects HOT 2
- Ubuntu PHP PPA has dropped support for Bionic HOT 2
- Missing licenses for npm packages HOT 6
- Prune unnecessary decisions when packages/LicenseFinder improves HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from licensefinder.