Add keyboard shortcuts

[pixelated]

Add keyboard shortcuts

[jeffhsta]

The implementation of shortcuts is done. Now we need create a window to show to the user shortcuts available

[giovaneliberato]

I did QA on this issue.

Most of the shortcuts works fine, except for the previous and next emails.
Another thing to point is that the send shortcut only works with control and doesn't support command. This may not be so intuitive for mac users.

ps: there's no unit tests for this feature :(

[re-nobre]

I also tested here and found one not expected behavior:
when I press "ctrl + enter" to send an email, one more line is added on the email.

[bwagnerr]

I reverted it, because the focus logic broke the all the functional tests, I'll move this back to the backlog for now

[giovaneliberato]

Another bug: it is not possible to copy any text because it triggers the compose shortcut

[jeffhsta]

I implemented that feature using linux, it means that I didn't test using "command" just implemented for "Shift", "Ctrl" and "Alt" on shortcuts, that I guess is the issue.

[treppo]

i started working on this in a fork https://github.com/treppo/pixelated-user-agent/tree/keyboard-shortcuts.
does it make sense to merge this in pieces, say a piece for opening and closing the compose box with the and keys or do a big pull request once the feature is completely implemented?
i wonder if this should be tested by a feature test. i wrote one for it (treppo@1b6d8b2) but can't get it to work – the screenshots tell me it doesn't open the compose box when i send a . i'm not very familiar with python-selenium and not too sure if calling #send_keys on the body tag is the problem.

[treppo]

so far implemented:

• Previous mail on the list/move up: Up or "k"
• Next mail on the list/move down: Down or "j"
• Check current email's checkbox: x
• Close open email: Esc
• Send: Command/Control + Enter
• Compose: c
• Focus on search input: / or "s"
• Tag email (open "new tag" input): t
• Open keyboard shortcuts map: ?
• Reply: r
• Reply to all: a
• Forward: f
• Delete: #

[bwagnerr]

hello!
I would suggest you open a PR from that branch, even if it is not ready, so we can follow you on the solution and help seeing the code.

[bwagnerr]

@treppo A good thing would be to create a pull request with the base implementation (the base for using and creating shortcuts) and then implement them on your pace, with pull requests for the changes.

[treppo]

@bwagnerr I opened the PR to track the progress. I don't quite know how I should make a base for shortcuts as I think they work just as any other flightjs component.
So far I've implemented all the shortcuts that don't change the state of the mail list (as I think that will be the most complicated part).