Streaming Issue

[sachinvas]

Streaming Issue

[pixelglow]

I've ran your code against your given zip file, then fixed it to make it run correctly:

    NSInteger bytesRead;
    NSUInteger chunkSize = (archiveEntry.uncompressedSize < 512) ? archiveEntry.uncompressedSize : 512;
    NSMutableData *streamData = [NSMutableData data];
    [inputStream open]; // 1.
    do {
        streamData.length = chunkSize;
        bytesRead = [inputStream read:(uint8_t *)streamData.mutableBytes maxLength:chunkSize];
        bytesRead = (bytesRead < 0) ? 0 : bytesRead;
        if (bytesRead != 0) {
            streamData.length = bytesRead; // 2.
            [destinationHandle writeData:streamData];
        }
    } while (bytesRead);
    [inputStream close]; // 3.

1. The new stream is unopened by convention, so you'll need to open it before use.
2. Having read into the buffer, you'll need to truncate it to the actual number of bytes read, otherwise it is possible to write rubbish data into the file handle.
3. The stream should be closed after use.

I've confirmed that the extracted file is byte-for-byte identical to using command-line unzip.

Hope that helps!

[sachinvas]

Thank you so much. It helped a lot and one more thing can you please add
the Archive Decryption Header this is used to validate the password as
mentioned by the PKWARE?

Regards,

Sachin Vas
On Apr 4, 2014 11:13 AM, "Glen Low" [email protected] wrote:

I've ran your code against your given zip file, then fixed it to make it
run correctly:

NSInteger bytesRead;
NSUInteger chunkSize = (archiveEntry.uncompressedSize < 512) ? archiveEntry.uncompressedSize : 512;
NSMutableData *streamData = [NSMutableData data];
[inputStream open]; // 1.
do {
    streamData.length = chunkSize;
    bytesRead = [inputStream read:(uint8_t *)streamData.mutableBytes maxLength:chunkSize];
    bytesRead = (bytesRead < 0) ? 0 : bytesRead;
    if (bytesRead != 0) {
        streamData.length = bytesRead; // 2.
        [destinationHandle writeData:streamData];
    }
} while (bytesRead);
[inputStream close]; // 3.

1. The new stream is unopened by convention, so you'll need to open it
   before use.
2. Having read into the buffer, you'll need to truncate it to the
   actual number of bytes read, otherwise it is possible to write rubbish data
   into the file handle.
3. The stream should be closed after use.

I've confirmed that the extracted file is byte-for-byte identical to using
command-line unzip.

Hope that helps!

Reply to this email directly or view it on GitHubhttps://github.com//issues/60#issuecomment-39533521
.

[pixelglow]

At the moment, I don't have any plans to offer Central Directory Encryption which uses the Archive Decryption Header, but I would welcome any code contributions here!