Comments (9)
Running the rainforest qa job manually didn't work. The {{ github.sha }}
value is b120c2a2470da2f478201204e8f878137a7361e9
which is not present in datadog (see here).
We may need to run the rainforest qa job as part of the release pipeline because the sha is dependent on the event that triggered the workflow, see docs:
The commit SHA that triggered the workflow. The value of this commit SHA depends on the event that triggered the workflow. For more information, see "Events that trigger workflows." For example, ffac537e6cbbf934b08745a378932722df287a53.
from pixiebrix-extension.
cc @fregante
from pixiebrix-extension.
Isn't that a matter of uploading the sourcemaps in the rainforest.yml workflow?
We could if we wanted too. I'm not aware there's any problems with uploading extra source maps to Datadog (e.g., if there's a max size across all maps/if we were to get billed for them)
from pixiebrix-extension.
Both the mv2 and mv3 build logs show sourceMapPublicUrl
is set:
- mv2: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/7563418803/job/20595791849#step:5:28
- mv3: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/7563418803/job/20595792088#step:5:28
So not sure how it's nullish here:
pixiebrix-extension/webpack.config.mjs
Lines 218 to 219 in 13f0d36
from pixiebrix-extension.
There is no dynamichost
string in the zip file produced by that run (build-production.zip). Did you upload that bundle?
https://github.com/pixiebrix/pixiebrix-extension/actions/runs/7563418803
The error specifically mentions that string, so it must be present in the bundle, but which bundle? This isn't a Datadog config/upload issue yet
from pixiebrix-extension.
build-production.zip
includes sourcemaps URLs like this one, which is valid and it exists:
//# sourceMappingURL=https://pixiebrix-extension-source-maps.s3.amazonaws.com/sourcemaps/build/c0e5cacc39b865790973c99cac04ebc523db8ecf/mv2/browserActionInstantHandler.js.map
from pixiebrix-extension.
Hmm, not sure how these could get out of sync:
- Value that's submitted in errors comes from here:
pixiebrix-extension/webpack.config.mjs
Line 219 in 13f0d36
- Value that's in the build comes from here:
pixiebrix-extension/webpack.config.mjs
Line 171 in 13f0d36
There is no dynamichost string in the zip file produced by that run (build-production.zip). Did you upload that bundle?
Hmm, that's odd - that's a good place to dig into first. We'd expect to see that string somewhere in there
from pixiebrix-extension.
Re-opening because this is still broken
from pixiebrix-extension.
which is not present in datadog
Isn't that a matter of uploading the sourcemaps in the rainforest.yml
workflow?
from pixiebrix-extension.
Related Issues (20)
- Add icon and tooltip to Doc Builder button elements
- GSheets Add Row sheet validation - Slice 2 - No blank columns between headers
- Slice 3 - Headers must be in the first row of the sheet
- Slice 4 - Config option for "Require all headers"
- Slice 5 - Config option for "Require only known headers"
- Slice 6 - Config option for "Require sheet is visible"
- Avoid duplicate error notifications on screen HOT 1
- Error copying mod with optional integrations
- Merge the "Restricted page" popup into the MV3 sidebar HOT 1
- Page Editor: Cannot destructure property "blockId" HOT 3
- Unable to "Render Panel" when the host pattern doesn't match HOT 1
- Slice 2: handle tab navigation (non-SPA) for PixieBrix sidebar in MV3 builds
- Add webpack configuration for removing unused DocumentView.js artifact
- Empty starting columns break the `checkAllValueHeadersExist` function
- UiPath assistant not connecting in Page Editor
- Phase 3: Add support for only running trigger on visible tab on mod activation
- Upgrade msw to v2
- Brick History dropdown is laggy/freezing
- Some bricks causing RJSF to infinite loop on shouldRender locally HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pixiebrix-extension.