Giter Site home page Giter Site logo

Comments (2)

twschiller avatar twschiller commented on August 22, 2024 1

It would be great if these retries could also be tied to chatter (i.e., a "READY" message), to avoid unnecessary pauses due to getting unlucky with the re-try interval

One example use case being context menus:

  1. user click context menu
  2. background page listener gets menu event
  3. background page injects content script
  4. background page waits for content script to be initialized
  5. background page sends context menu event

from webext-messenger.

fregante avatar fregante commented on August 22, 2024

I think this would cause noise because it'd travel on the same channel that sends the actual message.

From the content script’s perspective:

  1. The tab opens
  2. CS loads
  3. Messenger sends READY… to who? Ok, let's send it to background for now
  4. Now background isn't ready… so should it start its own retry loop for this READY message?

After #18, retries happen when the connection fails entirely, which is when onMessage has not been called at all in the context. The failure is immediate and, I'd expect, pretty lightweight, so I'd rather just retry frequently instead.

I think that for this intent, the time a READY message would save is minimal.

from webext-messenger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.