Giter Site home page Giter Site logo

Comments (2)

twschiller avatar twschiller commented on August 22, 2024

I'm not sure I'm 100% clear when you say it "handler" refers to:

  1. The custom handler logic
  2. The messaging framework listener + the custom handler logic

Is handler and listener the precise terms?

Philosophically, if the caller is sending a "notification" and therefore doesn't care about the fulfilled response, they shouldn't receive the error messages thrown by the custom handler

If the an error is thrown in the handler, my vote would be to let the unhandledrejection handler handle it. Or, to allow the context to register a method that listens for handler errors

from webext-messenger.

fregante avatar fregante commented on August 22, 2024

I'm not sure I'm 100% clear when you say it "handler" refers to:

In my question I refer specifically to the error handler. By re-throwing I mean:

 void sendMessage().catch((error: unknown) => { 
   const communicationError = new CommunicationError(type + " notification failed");
   communicationError.cause = error;
   throw communicationError;
 });

Is handler and listener the precise terms?

I rarely use listener, but it sounds interchangeable with handler if we're referring to functions that are called by event emitters.

If the an error is thrown in the handler, my vote would be to let the unhandledrejection handler handle it. Or, to allow the context to register a method that listens for handler errors

Great, so I'll use the pattern I just suggested.

from webext-messenger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.