Giter Site home page Giter Site logo

Comments (6)

bichotll avatar bichotll commented on May 21, 2024 1

Sure thing. I'll work on that soon-ish 👍

from pixi-react.

inlet avatar inlet commented on May 21, 2024

I believe this should be up to the developer. PIXI memoizes the elements to render, clears the canvas and redraw the elements back to improve performance.

If you're using the Graphics.draw prop, you can simply add g.clear() before you draw another rectangle. See this example: https://codepen.io/inlet/pen/RMLJKm?editors=0011

image

We could clear the graphics before the prop draw is called here, but I think this is not what you want as a developer.

from pixi-react.

inlet avatar inlet commented on May 21, 2024

Closing issue now, please let me know if you think we should reopen it.

from pixi-react.

bichotll avatar bichotll commented on May 21, 2024

Yes. I'm using g.clear() :)

I just think it would be helpful for the user to let them know that.
My point is: If they are not familiar enough with Pixi, they may expect that passing a new prop to the Graphics component, it would just clear the Graphics component "canvas" and write on a blank canvas (You have to explicitly call the method .clear() in order to have that desired behaviour).

That actually confused me - when it happened to me - until I found out what it was going on.

Again, if that make sense to you, I can create a PR (an update of the docs with the note).
It's not a big deal and it's not part of the library, but it's a good thing to know - at least for newbies.

from pixi-react.

inlet avatar inlet commented on May 21, 2024

Good point, would be great if you add this to the README. Thanks!

from pixi-react.

inlet avatar inlet commented on May 21, 2024

Hi @bichotll,

I've added a note to the Graphics doc, see:
https://reactpixi.org/#/components/graphics

from pixi-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.