When testcase is not right

[Greegko]

When testcase is not right

[pjurczynski]

Wrong in terms:

• it's a broken test (tests wrong assumptions)

Should be removed by the other prisoner with a description why it was removed. Write a new proper test in place.

You can do some more refactor.. but your job is basically done.

• It goes too fast ahead.

Decide by yourself if you want to take a risk and try to implement nonetheless. Proceed as normal.

But maybe it's just one step ahead? Then maybe just write a missing test and implementation. The other test leave for the other inmate.

• It's testing the sad path (throwing errors, bad arguments, etc)

Your call, you might want to implement it either way and proceed normally. But please leave a comment on the offending commit.

---

That's my take on it, what do you think?

[pjurczynski]

Now I see where the question came from ;).

I think it can also be approached the way you did it. But now I should only write a new test without the implementation. That's kind of punishment for writing a bad test?

[Greegko]

Well in TTD, if someone is writing wrong test, usually pass back to fix it because maybe they have to rethink again. In our case that would create a long delay. Also the case could be, the other person would do somehow differently and not consider a case at the early stage.