Add errors.Errorf method

[pkg]

Add errors.Errorf method

[davecheney]

probably errors.Errorf would be better.

On Tue, Apr 26, 2016 at 9:17 PM, Santiago Corredoira Lascaray <
[email protected]> wrote:

Hi, would it make sense to have a Newf method to avoid having to write
this?

errors.New(fmt.Errorf("something %v", x))

If you think it does I can make a PR.

Thank you

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#13

[scorredoira]

yes, much better, Newf didn't sound right :)

[scorredoira]

I saw the note. So how should I do it, amend to the last commit, two commits or create a new PR? Also, I didn't think it was worth it to add a test for such a simple addition. Is it OK?

[davecheney]

I saw the note. So how should I do it, amend to the last commit, two commits or create a new PR? Also, I didn't think it was worth it to add a test for such a simple addition. Is it OK?

Just amend the existing PR.

Please add a test, everything needs a test to ensure it continues to work. Adding an example means we get documentation for free.