Comments (3)
I buy the argument in your third point. Feel free to send a PR, don't
forget to update the docs and the package doc and the README. sorry for the
duplication
On Wed, 25 May 2016, 09:12 Mat Ryer, [email protected] wrote:
This might seem a little strange, but I think cause as an argument name
to Wrap and Wrapf is unnecessary. I wonder if err might be good enough?Here are some reasons:
- it's obvious that we're wrapping an error that caused the need to
add context- there's only one argument of type error
- it is possible the argument is not the 'root' cause, so in a
sense, isn't the 'cause'- IDE plugins will autofil and most of the time, the variable name
would be err so you can just tab past itVery minor issue, and mainly I'm trying to save myself two key-presses
each time I use this (which I will every day).—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32
from errors.
Actually, the error passed to Wrap and friends it's the cause. Error x is
caused by error y, and error y may either be the root cause or be
symptomatic of another.
But still send a PR to rename cause to err in the formal parameters. Its
not important enough to be different.
On Wed, 25 May 2016, 09:18 Dave Cheney, [email protected] wrote:
I buy the argument in your third point. Feel free to send a PR, don't
forget to update the docs and the package doc and the README. sorry for the
duplicationOn Wed, 25 May 2016, 09:12 Mat Ryer, [email protected] wrote:
This might seem a little strange, but I think cause as an argument name
to Wrap and Wrapf is unnecessary. I wonder if err might be good enough?Here are some reasons:
- it's obvious that we're wrapping an error that caused the need to
add context- there's only one argument of type error
- it is possible the argument is not the 'root' cause, so in a
sense, isn't the 'cause'- IDE plugins will autofil and most of the time, the variable name
would be err so you can just tab past itVery minor issue, and mainly I'm trying to save myself two key-presses
each time I use this (which I will every day).—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32
from errors.
from errors.
Related Issues (20)
- Proposal: add errors.Is and errors.As
- RFC: Allow custom StackTraces
- func Is() does not works with errors.Wrap or errors.Wrapf HOT 3
- Cause() behavior has changed HOT 11
- respect -trimpath build flag HOT 3
- Unwrap doesn't return the base error HOT 7
- Questions about extending annotations HOT 5
- undefined errors.Wrap HOT 2
- How to change format return wrapped error message HOT 2
- Stacktrace don't print all stack HOT 6
- errors.Wrap() created bugs in our codebase. HOT 3
- StackTrace.Format with "%+v" includes a leading newline HOT 1
- A new error caused by another error HOT 7
- Demo
- Change Wrap() to return an error even if we provide nil HOT 3
- return *stack instead of stack HOT 2
- Wrap() duplicates call stack HOT 6
- Elegant way to check error is wrapped HOT 4
- `Errorf` should be able to wrap errors HOT 4
- Package errors looking for new maintainers HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from errors.