Comments (8)
Hey @nockty, thanks for reaching out. You actually caught me off on paternity leave, which is the reason why the repository was basically frozen for the better part of this year. This is my bad -- I did not hand over this specific project before I left. Sorry about that!
But I'm back now, and really happy that DD is interested on helping maintain the library.
I know that lots of people rely on vtprotobuf
at this point, including Vitess, but the project already does 100% of what we required it to do for Vitess RPC, so I've been finding it hard to spend more of my time working on it. Having maintainers that are not tied to Vitess itself will be helpful to ensure that vtprotobuf
covers more use cases.
I'm gonna start by discussing the security implications of this internally. We may require to spin-off this into its own organization before we can add external contributors to the project. I'll let you know asap. Thanks again for your interest!
from vtprotobuf.
Hey! I've reached out to PlanetScale's legal team and we're ironing out the last kinks. My goal is to add @nockty as a committer to this repository some day this week, since he has kindly offered his assistance on triaging and merging PRs. To anybody else who's is interested on helping out, please follow the normal OSS process: open PRs, review PRs, contribute in issues, etc.
As for final decisions on features: I intend to keep the final say on the direction of the project because the main goal of vtprotobuf
is to enhance the Protocol Buffers performance in Vitess. Anything that regresses performance on the codebase or conflicts with it will not make it into the library. Besides that, I'm not fundamentally opposed to adding extra functionality to the library, and I'm easily swayed by good technical arguments, so I'm sure the project will continue to be very generally useful to the general public. As you're probably aware of, Vitess is rather representative of a large-scale Go project.
from vtprotobuf.
Hi @vmg ,
I too would like to offer support from TriggerMail to maintain this too! This is an awesome library and I would love to see it supported going forward.
Thanks,
Glenn
from vtprotobuf.
Hi @vmg, thank you for getting back to us, and congratulations on your paternity leave! It's completely understandable that life sometimes takes precedence.
I'm glad to hear that you're back and the project is getting attention again. It's exciting that DD's interest in maintaining vtprotobuf can align with the project's future and it's wonderful to see such positive engagement from the TriggerMail team as well.
I'm really looking forward to hearing from you about the next steps. Thanks for your responsiveness and dedication to the project!
from vtprotobuf.
Hi,
@nockty thanks for initiative and for rising this question!
@vmg here at Uber we're also looking for an alternative to outdated and abandoned gogo/protobuf project. And vtProto seems really promising!
But still we want to understands the desired future of this project:
- Does (will?) project have multiple owners/admins who may support activity, including sorting out issues, PRs and new releases?
- Who and how is (will?) making decision about features and approaches: what should be implemented, what should be left out of scope, etc.
As we're interested in this project, we also offer our help and participation in this project along with @nockty and @gnagel (at companies behind them) who already expressed their will.
Upd 02.10, we decided to move forward with a homemade tool, so I may be considered only as an external contributor.
Thanks!
from vtprotobuf.
As a hint for people interesting on contributing to the library: I think the main open issue right now blocking our next release is (de)serialization support for well-known types. There's an open PR that implements it, but it's large and complex and I haven't gotten around to reviewing it yet. Testing it in your own projects and giving feedback would be immensely helpful.
from vtprotobuf.
@nockty: 👋 welcome back from your holidays! I've given you triage access to the repository. Thanks again for your interest on the project and let me know what can I do to make your life easier.
from vtprotobuf.
Awesome, thank you for your trust @vmg. I'll do my best to ensure that vtprotobuf
succeeds in covering more use cases. I'm also thrilled to see that the project is getting active again, that's exciting!
I'll let you know if I need anything but in the meantime feel free to provide feedback at anytime so that I'm helping the project move in the right direction.
from vtprotobuf.
Related Issues (20)
- Uncompilable code generated for repeated groups
- Duplicated code generated for GRPC client/server HOT 1
- Panic after WKT commit: assignment to entry in nil map HOT 2
- Extensions are not encoded
- docs/feature: Nested ReturnToVTPool() HOT 4
- bug: oneof field that includes bytes field yields invalid ResetVT method
- Supporting Embedded and Nullable features from gogo proto HOT 2
- bug: Broken ResetVT generation for optional message HOT 1
- bug: grpc client methods does not use qualified idents
- feature: poolable messages paths with wildcard HOT 2
- unmarshal_unsafe feature produced code does not compile: "Cannot use intStringLen (type int) as the type IntegerType" HOT 1
- Run vtproto multiple times on different files of the same package HOT 3
- bug: IsMap not checked on message field's ReturnToVTpool
- bug: UnmarshalUnsafe panics when map values are empty strings HOT 2
- Request for New Release that Includes Well-Known Type Support HOT 4
- gRPC codec has different semantic on Unmarshal than the default one HOT 1
- v0.6.0 is creating issues in ubuntu20 HOT 2
- wrong pool unmarshal slize HOT 3
- Add optional unsafe operations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vtprotobuf.