Giter Site home page Giter Site logo

Comments (3)

louisgv avatar louisgv commented on May 26, 2024

@roedesh I'm on it!

a: waiting for selector `#publishButton` failed: timeout 30000ms exceeded
    at new d (/home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:36:35640)
    at waitForSelectorInPage (/home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:36:33752)
    at Object.A.queryOne.u.waitFor (/home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:[23](https://github.com/roedesh/copyguard/runs/5338858177?check_suite_focus=true#step:6:23):67036)
    at waitForSelector (/home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:36:31998)
    at A.waitForSelector (/home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:36:47436)
    at B.waitForSelector (/home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:36:99750)
    at /home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:169:9097
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/plasmo-corp/bpp/v1/dist/index.js:8:2[30](https://github.com/roedesh/copyguard/runs/5338858177?check_suite_focus=true#step:6:30)9
    at new Promise (<anonymous>)

This is weird, can you double check to see if Edge store was actually updated? The error above only pertains to store that uses Puppeteer (temporary solution until we reverse engineer their store API or use their official API). I suspect it failed and was not able to submit at all.

I also get this server response error: Server response: Duplicate add-on ID found. (status: 400)

This comes from the mozilla store, let me double check. I thought I added a logic to dedupe the id if it exists in the manifest. This error occured because the manifest has an id: https://github.com/roedesh/copyguard/blob/main/dist/manifest.json#L8, and the keys.json also have an id.

Regarding the firefox issue, I will trace down the error and either catch and remove the id from the keys if manifest has gecko.id. For the time being, a quick work around to see if chrome and firefox publish finished properly is to remove the extId from firefox, and comment out the edge store:

{
"chrome:" {},
"firefox": {},
"#edge": { //etc }
}

from bpp.

louisgv avatar louisgv commented on May 26, 2024

Work on this is being done here: PlasmoHQ/bms#9 <= once merged into upstream, we will proceed with updating bpp dependency.

So far, it seems the edge extension store has changed quite a bit compared to previous revision. Some identifier have been deprecated.

For future implementation, using the extension submission API is probably preferred: https://docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/publish/api/using-addons-api <- this API is private preview only at the moment, hopefully someone from MSFT can help giving access?

from bpp.

roedesh avatar roedesh commented on May 26, 2024

The Edge store did update, the new .zip file was added, but not published yet.

For the Firefox step, I believe I tried it twice, once with and once without the "extId" parameter, and both gave the duplicate error. But I will try it again without the "extId" when I have a new version ready.

from bpp.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.