Comments (4)
@hertg I am not working on this, happy if you provide a PR. Not 100% sure if there are more places which need to be fixed, I think my list should cover all (?) but better if you check if the constructor
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 82 to 84 in a77da07
gets called somewhere else.
Thanks!
from playframework.
Hi, @hertg! Good catch, you are right! π
Do you want to create a pull request to fix that?
from playframework.
oh wow, yeah this is a bug.
Actually, not just the withCookies
method is affected, but also these methods need to pass `attrsΒ΄. Probably this was overlooked by me when I implemented result attributes.
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 266 to 269 in a77da07
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 358 to 360 in a77da07
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 548 to 550 in a77da07
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 561 to 564 in a77da07
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 572 to 574 in a77da07
playframework/core/play/src/main/java/play/mvc/Result.java
Lines 582 to 584 in a77da07
from playframework.
@ihostage I could probably prepare a PR tomorrow or later this week
@mkurz unless you are already active on it? I'm assuming the list you posted is non-exhaustive?
from playframework.
Related Issues (20)
- Replace `3.0.x` with next version HOT 5
- SSL certificate for www.playframework.com is expired HOT 2
- Search in documentation does not work HOT 1
- Support for Partitioned cookie attribute (AKA CHIPS) / make cookies more flexibel HOT 1
- Asset changes in subprojects HOT 2
- Recommend Scala Metals + VSCode as an IDE on this page: https://www.playframework.com/documentation/2.9.x/IDE HOT 1
- Timeout issue when using AsyncCacheApi and custom http filter HOT 2
- [2.8.20] CVE-2023-44487 in akka-http-core HOT 1
- Support for Application Secret rotation
- play 2.9 is trying to fetch guice-6.0.0-no_aop jar, caused not found error HOT 6
- Play gradle plugin fails to create playRun task when no compileScala task found in a project
- Dependency Dashboard
- Apache Pekko doesn't support autogenerated TLS certs HOT 1
- Application secret from env variable does not work HOT 3
- UncheckedExecutionException: java.lang.IllegalStateException: Unable to load cache item HOT 12
- [UncheckedExecutionException: java.lang.IllegalStateException: Unable to load cache item] HOT 2
- Sbt dist command creates invalid .bat file under Windows HOT 2
- Gitandpio HOT 1
- Android HOT 1
- Brosver HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playframework.