Comments (4)
@mxschmitt I verified that it works. A question though. The implementation has this:
module.exports = { configs: { recommended: { env: { node: true, jest: true, }, globals: { browser: true, context: true, page: true, jestPlaywright: true, } } }, }Isn't this more proper?
module.exports = { configs: { recommended: { env: { shared-node-browser: true, jest: true, }, globals: { browser: true, context: true, page: true, jestPlaywright: true, } } }, }Reason being that you can just
document.
in many of the Playwright functions that runs inside the browser.
good catch, will adjust this in a bit! :)
from jest-playwright.
@thernstig that's make sense
from jest-playwright.
@thernstig could you try https://github.com/mxschmitt/eslint-plugin-jest-playwright?
Should fit for your needs, if yes then we can refer to this in the README.
from jest-playwright.
@mxschmitt I verified that it works. A question though. The implementation has this:
module.exports = {
configs: {
recommended: {
env: {
node: true,
jest: true,
},
globals: {
browser: true,
context: true,
page: true,
jestPlaywright: true,
}
}
},
}
Isn't this more proper?
module.exports = {
configs: {
recommended: {
env: {
shared-node-browser: true,
jest: true,
},
globals: {
browser: true,
context: true,
page: true,
jestPlaywright: true,
}
}
},
}
Reason being that you can just document.
in many of the Playwright functions that runs inside the browser.
from jest-playwright.
Related Issues (20)
- [Question] Access to the displayName: 'edge' from the test file HOT 1
- "useDefaultBrowserType" property leads to "no tests were found"
- Provides the method for getting the `baseURL` HOT 1
- Support playwright v1.15.0 HOT 1
- Add strictness option to config HOT 1
- jestPlaywright is not defined HOT 3
- Unable to switch to inner frame in playwright HOT 1
- Question: history.pushState instead of full page load? HOT 2
- RevoGrid Problem HOT 1
- Not Able to Use jest-playwright-preset in Playwright Docker Container HOT 5
- Got the error >>TypeError: this[(intermediate value)(intermediate value)(intermediate value)] is not a function HOT 3
- Support Jest 28 HOT 1
- how to specify record starting point HOT 2
- Test suites fail to lauch after upgrading playwright to 1.23.0 version HOT 4
- ReferenceError: page is not defined after upgrading to version 2.0.0 and jest 28.1.3 HOT 1
- TypeScript Build Failure: global.d.ts(233,5): error TS2709: Cannot use namespace 'JestConfig' as a type. HOT 3
- Support Jest 29 HOT 2
- [Question/Help] Record video for firefox
- Support Playwright Android Integration
- Support disabling animations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jest-playwright.