Giter Site home page Giter Site logo

Comments (4)

mxschmitt avatar mxschmitt commented on May 22, 2024 1

@mxschmitt I verified that it works. A question though. The implementation has this:

module.exports = {
  configs: {
    recommended: {
      env: {
        node: true,
        jest: true,
      },
      globals: {
        browser: true,
        context: true,
        page: true,
        jestPlaywright: true,
      }
    }
  },
}

Isn't this more proper?

module.exports = {
  configs: {
    recommended: {
      env: {
        shared-node-browser: true,
        jest: true,
      },
      globals: {
        browser: true,
        context: true,
        page: true,
        jestPlaywright: true,
      }
    }
  },
}

Reason being that you can just document. in many of the Playwright functions that runs inside the browser.

good catch, will adjust this in a bit! :)

from jest-playwright.

mmarkelov avatar mmarkelov commented on May 22, 2024

@thernstig that's make sense

from jest-playwright.

mxschmitt avatar mxschmitt commented on May 22, 2024

@thernstig could you try https://github.com/mxschmitt/eslint-plugin-jest-playwright?
Should fit for your needs, if yes then we can refer to this in the README.

from jest-playwright.

thernstig avatar thernstig commented on May 22, 2024

@mxschmitt I verified that it works. A question though. The implementation has this:

module.exports = {
  configs: {
    recommended: {
      env: {
        node: true,
        jest: true,
      },
      globals: {
        browser: true,
        context: true,
        page: true,
        jestPlaywright: true,
      }
    }
  },
}

Isn't this more proper?

module.exports = {
  configs: {
    recommended: {
      env: {
        shared-node-browser: true,
        jest: true,
      },
      globals: {
        browser: true,
        context: true,
        page: true,
        jestPlaywright: true,
      }
    }
  },
}

Reason being that you can just document. in many of the Playwright functions that runs inside the browser.

from jest-playwright.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.