Giter Site home page Giter Site logo

Comments (8)

artis3n avatar artis3n commented on August 17, 2024

Confused with what happens with go install vs. the building in the CI workflow and the Dockerfile that explicitly add the template variable, but I am assuming that https://github.com/plexsystems/konstraint/blob/main/internal/commands/default.go#L23 does not get populated without a default during go install github.com/plexsystems/konstraint@latest.

from konstraint.

jpreese avatar jpreese commented on August 17, 2024

Correct. Using go install won't provide a version because the version is set during CI.

from konstraint.

artis3n avatar artis3n commented on August 17, 2024

Ah so this is intentional? Hard to know when to update if you miss the release notifications from GitHub.

from konstraint.

jpreese avatar jpreese commented on August 17, 2024

Unless I'm mistaken, it's not possible to set a version when using go install. This is the tradeoff between using a pre-built binary or doing it from Go.

from konstraint.

artis3n avatar artis3n commented on August 17, 2024

That is my understanding too. So your recommended approach is to use the Docker container? If so my suggestion would be to highlight that more directly in the README, above the go install.

from konstraint.

artis3n avatar artis3n commented on August 17, 2024

It is just the version command, not a big deal. Just want to better understand y'all's desire for the project

from konstraint.

jpreese avatar jpreese commented on August 17, 2024

There really isn't a recommended approach, just whatever is convenient for the end user. I think it's pretty accepted that using a go install flow doesn't provide versioning/commit/date details of the build, but is very convenient to use.

from konstraint.

artis3n avatar artis3n commented on August 17, 2024

Makes sense - my lack of familiarity with publishing go projects, it seems.

from konstraint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.