Giter Site home page Giter Site logo

Comments (3)

edublancas avatar edublancas commented on June 8, 2024

this sounds like a regression error. we added executor in 0.22.4, can you try using 0.22.3?

@mehtamohit013: do you remember why we added this validation? looks like a bug. allowing people to use a custom papermill engine sounds reasonable

from ploomber.

mehtamohit013 avatar mehtamohit013 commented on June 8, 2024

@edublancas
It seems papermill also uses the engine_name parameter. So, what does engine_name intend to do is, select from Papermill and ploomber-engine. We can completely remove the engine_name and use only the executor param or can use something like executor_name? The code should run fine with version 0.22.3.

from ploomber.

rmshkv avatar rmshkv commented on June 8, 2024

Thanks for looking into this! I tested with 0.22.3 and it works as expected (with executor_params changed to papermill_params)

from ploomber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.