startup error with yo-configured time widget

[plouc]

startup error with yo-configured time widget

[ThrowingSpoon]

I called the 'time' component directly. In:

(mozaik project folder)/node_modules/mozaik-ext-time/client.js

I changed the single line of code from:

module.exports = require('./lib/client');

to:

module.exports = require('./lib/components/Clock.js');

This does however generate a warning:

Warning: Something is calling a React component directly. Use a factory or JSX instead. See: http://fb.me/react-legacyfactory

Although the clock widget does appear to be working fine, does anybody know of any issues that may arise from calling this component directly?

Liam.

[plouc]

@mblakele I have to fix the generator to only require extension's client if it's available.

[plouc]

@ThrowingSpoon how do you instantiate the clock component ?
When you use mozaïk, the widget is instantiated using this code https://github.com/plouc/mozaik/blob/master/src/browser/components/Widget.jsx#L18
If you're curious, you can read more about this here https://gist.github.com/sebmarkbage/ae327f2eda03bf165261

[plouc]

@mblakele I fixed the issue with extra client declaration, see plouc/mozaik-generator@6480b10
Feel free to re-open this issue if it does not fix the problem.
(You'll have to update the yeoman generator)