Comments (3)
Good catch!
The sign was used for XRP values, but not for issued currencies. I made the
change and pushed it to github.
Thanks!
On Mon, Feb 10, 2014 at 12:28 AM, jargoman [email protected] wrote:
RippleBinarySerializer method readAmount line 129
You forgot to add the sign to BigDecimal fractionalValue
BigInteger biMagnitude = BigInteger.valueOf(longMagnitude);
should be...
BigInteger biMagnitude = BigInteger.valueOf(longMagnitude * sign);or if you'd rather
if (sign<0) {
fractionalValue.negate();
}Reply to this email directly or view it on GitHubhttps://github.com//issues/19
.
from jstellarapi.
should't this be closed as it is solved?
from jstellarapi.
Indeed, I thought I had.
from jstellarapi.
Related Issues (20)
- ledger_selector
- ledger_closed
- ledger_current
- Ledger API
- path_find API
- Subscription API & Callback/Notification
- Proof of work API
- Add logging facility
- Add build system
- Sign binary data on the client side
- Verify signature in client
- nice code HOT 1
- strip the s from seedaddress HOT 2
- Ripplebase58 decode HOT 4
- currency wire format HOT 4
- Memo Types HOT 9
- write to orderbook HOT 5
- Remove the libSodium dependency HOT 1
- Unable to sign transactions locally. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jstellarapi.