Comments (4)
I haven't worked on that branch for a while but I sent Zohaib the main code I had working for the boundary pores months ago. I assume what he has is better and more up to date so I'd say just delete that branch and if I need to anything else I will cross that bridge when it comes
from porespy.
The difference I see between add boundary regions and tom boundary function is
A: Removing connections between boundary cells
B: Specify at which face boundary cells are needed.
C: Boundary cells are 3 voxel wide
From last three months, I haven't used @TomTranter boundary function also so not sure about if he has made any other changes.
from porespy.
Why 3 voxels? Could this be an argument... In principle I have no problem with it but not sure why it's necessary. Specifying faces fine. I think I do remove interconnections but if I don't then I agree I should
from porespy.
Why 3 voxels?
This was added because the marching cube algorithm was not able to calculate the surface area on one voxel wide boundary cells. So 3 voxels wide boundary cells were used.
Could this be an argument
Yes, it can be added as an argument as well but I didn't observe its need in snow_dual until now.
from porespy.
Related Issues (20)
- Use "__all__" in files to declare imports
- Use templates in sphinx to generate module docs instead of autosummary directive in each init file
- Add function source to Results objects HOT 2
- Add generator function for inlets and/or outlets
- add seed argument to all generators
- Update set_mpl_style to set origin and interpolation
- pixel vs. voxel scaling HOT 1
- Add a packed_spheres function to unify gravity and electrostatic packings.
- Wrong porosity value on large images HOT 1
- Reporting a vulnerability
- cylinders should be renamed 'overlapping_cylinders' to be more consistent
- Total surface area of the network is greater than the area obtained directly from the image HOT 1
- Memory leak in diffusive_size_factor_DNS HOT 1
- Add logger.info to beginning and end of each function HOT 5
- Lower memory footprint for porosimetry and local_thickness HOT 1
- Would be helpful if `shape=[100, 100, 0]` was treated the same as `shape=[100, 100]`
- snow2 interested in only one phase HOT 3
- Visualization functions should optionally accept `ax` as argument
- Add flux tolerance as argument to `tortuosity_fd` (and possibly other effective solvers in the future)
- Update `satn_profile` to accept an already thresholded image
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from porespy.