Giter Site home page Giter Site logo

delete boundary_pores branch? about porespy HOT 4 CLOSED

pmeal avatar pmeal commented on May 25, 2024
delete boundary_pores branch?

from porespy.

Comments (4)

TomTranter avatar TomTranter commented on May 25, 2024

I haven't worked on that branch for a while but I sent Zohaib the main code I had working for the boundary pores months ago. I assume what he has is better and more up to date so I'd say just delete that branch and if I need to anything else I will cross that bridge when it comes

from porespy.

Zohaib-Atiq avatar Zohaib-Atiq commented on May 25, 2024

The difference I see between add boundary regions and tom boundary function is
A: Removing connections between boundary cells
B: Specify at which face boundary cells are needed.
C: Boundary cells are 3 voxel wide
From last three months, I haven't used @TomTranter boundary function also so not sure about if he has made any other changes.

from porespy.

TomTranter avatar TomTranter commented on May 25, 2024

Why 3 voxels? Could this be an argument... In principle I have no problem with it but not sure why it's necessary. Specifying faces fine. I think I do remove interconnections but if I don't then I agree I should

from porespy.

Zohaib-Atiq avatar Zohaib-Atiq commented on May 25, 2024

Why 3 voxels?

This was added because the marching cube algorithm was not able to calculate the surface area on one voxel wide boundary cells. So 3 voxels wide boundary cells were used.

Could this be an argument

Yes, it can be added as an argument as well but I didn't observe its need in snow_dual until now.

from porespy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.