Generated JSON: Add New Boolean Keys "is_block_type" and "is_inline_type"

[pml-lang]

Generated JSON: Add New Boolean Keys "is_block_type" and "is_inline_type"

[pml-lang]

it would be very useful to also have two new boolean keys representing the node type:
"is_block_type"
"is_inline_type"

Ok. I just wonder why there should be two more fields. Wouldn't it be enough to just have is_inline_type. Because in moustache you have 'Inverted Sections' that "will be rendered if the key doesn't exist, is false, or is an empty list".

Is there another reason why there should be two new fields?

having these redundant keys is not DRY, but hopefully it won't hurt either

Having type and is_inline_type is no problem in this context, because the JSON is machine-generated and, as you said already, consumed by machines too.

[tajmone]

Ok. I just wonder why there should be two more fields. Wouldn't it be enough to just have is_inline_type. Because in moustache you have 'Inverted Sections' that "will be rendered if the key doesn't exist, is false, or is an empty list".

You're absolutely right.

Is there another reason why there should be two new fields?

I was just just thinking in terms of consistent naming conventions in view of future similar keys matching to more than two values, in which case it would require providing three boolean keys. That's all. But yes, having a single boolean key is fine.

[ch Predefined Attribute

I have one question....

Now that we have the autogenerated markdown doc tags-info.md showing the node/tag properties, it's easier to track all the info from the JSON file.

I've noticed in the Default Attributes section the following:

• [ch → title → ]
• [image → source → ]

It appears that in the generated pml_tags.json the [ch node mentions having a "default_attribute_id":"title":

"id":"ch",
"type":"block",
"title":"Chapter",
"description":"A chapter or sub-chapter of the document." … etc. …
"attributes":[
    {
        … etc. …
    }
],
"default_attribute_id":"title",  <-- here!

I'm not quite sure how to interpret this. Wasn't the title attribute replaced with the [title node? What does this key/value pair represent exactly?

[pml-lang]

yes, having a single boolean key is fine.

Ok. The field is_inline_type has been added. Will be included in PML 2.3. New file: pml_tags.zip

Wasn't the title attribute replaced with the [title node?

You're absolutely right. I just forgot to remove it from default_attribute_id. It's now fixed, and already corrected in the above file pml_tags.json.

[tajmone]

Ok. The field is_inline_type has been added. Will be included in PML 2.3.

Great! Thanks.

You're absolutely right. I just forgot to remove it from default_attribute_id

Isn't the process entirely automated via introspection?

[pml-lang]

Isn't the process entirely automated via introspection?

It is (to create the JSON file). The problem was in the formal definition of node ch (line 26 in PML_chapter_formal_node). I had to change that line to default_attribute_id = null.

[pml-lang]

Fixed in PML 2.3.0.